1136533 - Remove about:media from beta

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P5)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

STR:

* Install aboutmedia.xpi
* Navigate to given URL
* open a tab and go to about:media

Expected results:
Media information

Actual results:
Title and "not well-formed" error in js console

I'm guessing it's the & in the URL that is derailing it.

Comment 1

[cajbir (:cajbir)]

Fix for plugin here: https://github.com/doublec/aboutmedia/commit/3998eee7269bf7592c0a677370ea098c75d85e5d
Built plugin: https://github.com/doublec/aboutmedia/blob/master/aboutmedia.xpi?raw=true

Comment 2

[cajbir (:cajbir)]

A fix is still needed for beta. Should we just remove the internal beta about:media code and go with the plugin?

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Yes. Lets drop the internal page.

Comment 4

[cajbir (:cajbir)]

Attachment: Remove about:media page on beta

This reverts part 4 patch in bug 1112424 so that "about:media" no longer works. Only beta has this code at the moment. The functionality has been replaced with an addon available from http://github.com/doublec/aboutmedia.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8571109 [details] [diff] [review]
Remove about:media page on beta

The AboutMedia:CollectData message handler in content.js should ideally be ported to the addon, so that it is e10s compatible and less hacky.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8571109 [details] [diff] [review]
Remove about:media page on beta

Approval Request Comment
[Feature/regressing bug #]: bug 1112424 added this page, aurora/beta only
[User impact if declined]: somewhat broken not-user-exposed about: page left in product
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: no risk, just removing a page that was recently addded
[String/UUID change made/needed]: none

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8571109 [details] [diff] [review]
Remove about:media page on beta

I agree with moving to the plug-in model. Let's drop this about: page from Beta. Beta+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8628f482efe0