All data could potentially be incorrectly evicted

RESOLVED FIXED in Firefox 37

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks: 1 bug)

Trunk
mozilla39
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox37 fixed, firefox38 fixed, firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
When we evict data, we attempt to align all sourcebuffers so they have the same start.

It incorrectly align all source buffers to the start of the one we currently adding data to rather than the one we are currently playing.

"Luckily" due to another bug in EvictBefore, the operation is usually a no-op.
(Assignee)

Comment 1

3 years ago
Created attachment 8569023 [details] [diff] [review]
Properly align source buffer starts with current decoder

Do not align sourcebuffers to the one we're currently adding to, but the currently playing one.
Attachment #8569023 - Flags: review?(cajbir.bugzilla)
(Assignee)

Updated

3 years ago
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED

Updated

3 years ago
Attachment #8569023 - Flags: review?(cajbir.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/da1cac8417ac
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
(Assignee)

Comment 4

3 years ago
need beta uplift
Flags: needinfo?(giles)
Comment on attachment 8569023 [details] [diff] [review]
Properly align source buffer starts with current decoder

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Longer rebuffering pauses playing MSE video.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: Risk is low. This is an isolated MSE-specific change.
[String/UUID change made/needed]: None.
Flags: needinfo?(giles)
Attachment #8569023 - Flags: approval-mozilla-beta?
Attachment #8569023 - Flags: approval-mozilla-aurora?
Attachment #8569023 - Flags: approval-mozilla-beta?
Attachment #8569023 - Flags: approval-mozilla-beta+
Attachment #8569023 - Flags: approval-mozilla-aurora?
Attachment #8569023 - Flags: approval-mozilla-aurora+
status-firefox37: --- → affected
status-firefox38: --- → affected
You need to log in before you can comment on or make changes to this bug.