1136576 - All data could potentially be incorrectly evicted

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

When we evict data, we attempt to align all sourcebuffers so they have the same start.

It incorrectly align all source buffers to the start of the one we currently adding data to rather than the one we are currently playing.

"Luckily" due to another bug in EvictBefore, the operation is usually a no-op.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Properly align source buffer starts with current decoder

Do not align sourcebuffers to the one we're currently adding to, but the currently playing one.

Comment 2

[Jean-Yves Avenard [:jya]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/da1cac8417ac

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/da1cac8417ac

Comment 4

[Jean-Yves Avenard [:jya]]

need beta uplift

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8569023 [details] [diff] [review]
Properly align source buffer starts with current decoder

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Longer rebuffering pauses playing MSE video.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: Risk is low. This is an isolated MSE-specific change.
[String/UUID change made/needed]: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4338ca996934

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5a0ed5076b4f