1136699 - Pull-to-refresh action is triggered when scrolling up the synced devices list

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Flaviu Cos]

Attachment: scroll the list.png

Environment: 
Device: Nexus 7 (Android 5.0.2);
Build: Nightly 39.0a1 (2015-02-25);

Preconditions:
- Make sure that the Sync Account have at least 8 devices synced.

Steps to reproduce:
1. Login into Sync;
2. Go to Synced tabs panel;
3. Scroll down the synced devices list;
4. Scroll up the synced devices list.

Expected result:
The synced devices list is scrolled up.

Actual result:
The Pull-to-refresh action is triggered.

Notes:
Please check the attached screenshot.

Comment 1

[:Margaret Leibovic]

Vivek or nalexander, are you aware of this issue?

Comment 2

[Aaron Train [:aaronmt]]

"- Make sure that the Sync Account have at least 8 devices synced."

Sounds like an edge case.

Comment 3

[Flaviu Cos]

(In reply to Aaron Train [:aaronmt] from comment #2)
> "- Make sure that the Sync Account have at least 8 devices synced."
> 
> Sounds like an edge case.

The Sync Account needs to have multiple devices synced at least once so the synced devices list becomes scrollable.

Comment 4

[Vivek Balakrishnan[:vivek]]

As part of 1129181, the SwipeToRefreshLayout now holds a LinearLayout with two ListViews and it doesn't correctly detect if the ListViews can scroll up. One possible solution would be to allow only either of the client or tabs list to be swipe-able. But this would look ugly as the swipe animation will appear for part of the screen instead of the entire width.

NIing antlam here to share his views on whether this is an acceptable tradeoff.

As agreed with nalexander over irc, I would submit a new patch to temporarily disabled swiping in split pane layout.

Comment 5

[Vivek Balakrishnan[:vivek]]

Attachment: 1136699.patch

Swipe to refresh layout is not enabled in the tablet landscape mode, which prevents the touch event from being intercepted.

Comment 6

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/68472846761f

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8570789 [details] [diff] [review]
1136699.patch

Approval Request Comment
[Feature/regressing bug #]: split pane remote tabs panel.
[User impact if declined]: bad scrolling interaction.
[Describe test coverage new/current, TreeHerder]: none.
[Risks and why]: very low.
[String/UUID change made/needed]: none.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/68472846761f

Comment 9

[Flaviu Cos]

Verified as fixed in build 39.0a1 2015-03-04;
Device: Asus Transformer Tab (Android 4.2.1).

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bdf310a1b1bc

Comment 11

[Flaviu Cos]

Verified as fixed in build 38.0a2 2015-03-05;
Device: Lenovo Yoga Tab 10 (Android 4.4.2).