Closed Bug 1136735 Opened 8 years ago Closed 8 years ago
crash in ns
INode::Get First Element Child() const with selectioncaret .enabled turned on on desktop
This bug was filed from the Socorro interface and is report bp-feba3b8e-65c6-4877-8cdb-150482150225. ============================================================= Steps to reproduce: 1. Enable selectioncaret.enabled on desktop (I tested on Mac), and restart. 2. In an open window, click on the location bar. This is caused by PresShell::GetSelectionCaretsStartElement() returning null, and the caller (SelectionCarets::GetStartFrameRectInner) not testing its return value. Ting-Yu, do you have time to fix this? Should be an easy fix. Thanks!
Ehsan, I can reproduce this locally. Investigating.
Assignee: nobody → tlin
Status: NEW → ASSIGNED
UL has no CanvasFrame. Hence no SelectionCarets elements. SelectionCarets should ignore the events if it cannot get its elements.
Attachment #8569593 - Flags: feedback+
Attachment #8569593 - Flags: feedback+ → feedback?(mtseng)
Comment on attachment 8569593 [details] [diff] [review] Ignore events if there's no SelectionCarets elements. (v1) Looks good. Do we need same check in TouchCaret?
Attachment #8569593 - Flags: feedback?(mtseng) → feedback+
(In reply to Morris Tseng [:mtseng] from comment #3) > Comment on attachment 8569593 [details] [diff] [review] > Ignore events if there's no SelectionCarets elements. (v1) > > Looks good. Do we need same check in TouchCaret? TouchCaret is fine. It's protected by IsDisplayable() at the beginning of HandleEvent().  http://hg.mozilla.org/mozilla-central/annotate/9b077c6f3d02/layout/base/TouchCaret.cpp#l594
Attachment #8569593 - Flags: review?(ehsan)
Attachment #8569593 - Flags: review?(ehsan) → review+
You need to log in before you can comment on or make changes to this bug.