Closed Bug 1136801 Opened 5 years ago Closed 5 years ago

"Advanced Address Book Search" lacks column for containing "Address Book" (shown by default, but optional)

Categories

(MailNews Core :: Address Book, defect)

defect
Not set

Tracking

(thunderbird38+ fixed)

RESOLVED FIXED
Thunderbird 39.0
Tracking Status
thunderbird38 + fixed

People

(Reporter: bugzilla2007, Assigned: sshagarwal)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1136798 +++
+++ This bug was initially created as a clone of Bug #1136792 +++
+++ This bug was initially created as a clone of Bug #170270 +++

STR

1 Open Address Book
2 Ctrl+Shift+F to show "Advanced Address Book Search"
3 Display Name contains: type "a", press Enter, ensure matches
4 Try to figure out containing AB of results; try column selector to show "Address Book" column

Actual
- no way to figure out the containing AB of found contacts

Expected
- new column in advanced AB search results: "Address Book" (shown by default, but can be hidden via column selector)

Needs string. Pls be fast. Only if too late, temporarily use existing column header from the column header in main AB list view.
Assignee: nobody → syshagarwal
No longer depends on: 1136792, 1136798
Blocks: 1136833
Attached patch Patch v1 (obsolete) — Splinter Review
I am using the same Addrbook.label as it is available in the included abResultsPaneOverlay.dtd file so no string changes are needed.
Attachment #8572558 - Flags: ui-review?(richard.marti)
Attachment #8572558 - Flags: review?(mkmelin+mozilla)
Attachment #8572558 - Flags: feedback?(acelists)
Attachment #8572558 - Flags: ui-review?(richard.marti) → ui-review+
Attachment #8572558 - Flags: review?(josiah)
Comment on attachment 8572558 [details] [diff] [review]
Patch v1

Review of attachment 8572558 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/ABSearchDialog.xul
@@ +149,5 @@
>            <treecol id="WorkPhone"
>                     persist="hidden ordinal width sortDirection"
>                     flex="1" label="&WorkPhone.label;"/>
> +          <splitter class="tree-splitter"/>
> +          <treecol id="addrbook"

Use id="Addrbook" like the label.
Attachment #8572558 - Flags: review?(mkmelin+mozilla)
Attachment #8572558 - Flags: review?(josiah)
Attachment #8572558 - Flags: review+
Attached patch Patch v1.1Splinter Review
Made the suggested change.

Thanks.
Attachment #8572558 - Attachment is obsolete: true
Attachment #8572558 - Flags: feedback?(acelists)
Attachment #8573307 - Flags: ui-review+
Attachment #8573307 - Flags: review+
Keywords: checkin-needed
Josiah pushed as https://hg.mozilla.org/comm-central/rev/2cc9dc33526b
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0
Should this land in TB 38?
Yes, but please let it ship as Nightlies before uplifting.
Blocks: 170270
No longer depends on: 170270
You need to log in before you can comment on or make changes to this bug.