1136801 - "Advanced Address Book Search" lacks column for containing "Address Book" (shown by default, but optional)

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #1136798 +++
+++ This bug was initially created as a clone of Bug #1136792 +++
+++ This bug was initially created as a clone of Bug #170270 +++

STR

1 Open Address Book
2 Ctrl+Shift+F to show "Advanced Address Book Search"
3 Display Name contains: type "a", press Enter, ensure matches
4 Try to figure out containing AB of results; try column selector to show "Address Book" column

Actual
- no way to figure out the containing AB of found contacts

Expected
- new column in advanced AB search results: "Address Book" (shown by default, but can be hidden via column selector)

Needs string. Pls be fast. Only if too late, temporarily use existing column header from the column header in main AB list view.

Comment 1

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch v1

I am using the same Addrbook.label as it is available in the included abResultsPaneOverlay.dtd file so no string changes are needed.

Comment 2

[Josiah Bruner [:jsbruner]]

Comment on attachment 8572558 [details] [diff] [review]
Patch v1

Review of attachment 8572558 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/ABSearchDialog.xul
@@ +149,5 @@
>            <treecol id="WorkPhone"
>                     persist="hidden ordinal width sortDirection"
>                     flex="1" label="&WorkPhone.label;"/>
> +          <splitter class="tree-splitter"/>
> +          <treecol id="addrbook"

Use id="Addrbook" like the label.

Comment 3

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch v1.1

Made the suggested change.

Thanks.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Josiah pushed as https://hg.mozilla.org/comm-central/rev/2cc9dc33526b

Comment 5

[Kent James (:rkent)]

Should this land in TB 38?

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Yes, but please let it ship as Nightlies before uplifting.

Comment 7

[Kent James (:rkent)]

Comment on attachment 8573307 [details] [diff] [review]
Patch v1.1

[Triage Comment]

http://hg.mozilla.org/releases/comm-aurora/rev/d5574ecdac1c