Closed
Bug 1136900
Opened 10 years ago
Closed 10 years ago
Make Settings a modal sheet rather than a Home Panel
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(1 file)
Currently, Settings is a Home Panel accessed as part of the Home Pager after tapping on the URL bar.
The latest mocks have Settings as a separate modal sheet (not a Home Panel) that slides up from the bottom of the app after tapping a standard gear icon in the tab list view.
This ticket tracks making that navigation change.
|
Assignee | |
Comment 1•10 years ago
|
||
bnicholson: the code here is pretty straight forward -- I'm working on re-implementing the existing work as we speak.
darrin: you might steal this review? It's pretty clear. You'll want to provide fresh iconography for the Tab Tray at some point.
Attachment #8569490 -
Flags: review?(dhenein)
Attachment #8569490 -
Flags: review?(bnicholson)
|
||
Updated•10 years ago
|
Attachment #8569490 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8569490 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/183
f+ from darrin on GH.
Attachment #8569490 -
Flags: review?(dhenein) → feedback+
You need to log in
before you can comment on or make changes to this bug.
Description
•