1136900 - Make Settings a modal sheet rather than a Home Panel

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

Currently, Settings is a Home Panel accessed as part of the Home Pager after tapping on the URL bar.

The latest mocks have Settings as a separate modal sheet (not a Home Panel) that slides up from the bottom of the app after tapping a standard gear icon in the tab list view.

This ticket tracks making that navigation change.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/183

bnicholson: the code here is pretty straight forward -- I'm working on re-implementing the  existing work as we speak.

darrin: you might steal this review?  It's pretty clear.  You'll want to provide fresh iconography for the Tab Tray at some point.

Comment 2

[Nick Alexander :nalexander [he/him]]

https://github.com/mozilla/firefox-ios/commit/1605b34ac61f5abafad2f0d4dac4f7a478fe4897

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8569490 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/183

f+ from darrin on GH.