Closed Bug 1136906 Opened 5 years ago Closed 5 years ago

Remove the parent arg from JS_NewObject

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(3 files, 1 obsolete file)

We have almost no consumers anyway.
Attachment #8569431 - Flags: review?(bobbyholley) → review+
Attachment #8569431 - Attachment is obsolete: true
Attachment #8569433 - Flags: review?(bobbyholley) → review+
Comment on attachment 8569426 [details] [diff] [review]
part 1.  Stop passing parents to JS_NewObject in ctypes code

Review of attachment 8569426 [details] [diff] [review]:
-----------------------------------------------------------------

I have a recollection of there being CTypes parent-tests in toolkit/components/ctypes at one point.  Recommend tryservering.
Attachment #8569426 - Flags: review?(jwalden+bmo) → review+
Attachment #8569432 - Flags: review?(jwalden+bmo) → review+
Try run at https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c41e32a1e3b says either we're ok or the tests are disabled.
(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #5)
> Comment on attachment 8569426 [details] [diff] [review]
> part 1.  Stop passing parents to JS_NewObject in ctypes code
> 
> Review of attachment 8569426 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I have a recollection of there being CTypes parent-tests in
> toolkit/components/ctypes at one point.  Recommend tryservering.

I think they were for the prototype chain, not the parent chain.
You need to log in before you can comment on or make changes to this bug.