1136906 - Remove the parent arg from JS_NewObject

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We have almost no consumers anyway.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Stop passing parents to JS_NewObject in ctypes code

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Stop passing a parent to JS_NewObject in xpconnect code

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Remove the parent arg from JS_NewObject

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Stop passing a parent to JS_NewObject in xpconnect code

Comment 5

[Jeff Walden [:Waldo]]

Comment on attachment 8569426 [details] [diff] [review]
part 1.  Stop passing parents to JS_NewObject in ctypes code

Review of attachment 8569426 [details] [diff] [review]:
-----------------------------------------------------------------

I have a recollection of there being CTypes parent-tests in toolkit/components/ctypes at one point.  Recommend tryservering.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Try run at https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c41e32a1e3b says either we're ok or the tests are disabled.

Comment 7

[Bobby Holley (:bholley)]

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #5)
> Comment on attachment 8569426 [details] [diff] [review]
> part 1.  Stop passing parents to JS_NewObject in ctypes code
> 
> Review of attachment 8569426 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I have a recollection of there being CTypes parent-tests in
> toolkit/components/ctypes at one point.  Recommend tryservering.

I think they were for the prototype chain, not the parent chain.

Comment 8

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b6971da3928
https://hg.mozilla.org/integration/mozilla-inbound/rev/d06271a6af45
https://hg.mozilla.org/integration/mozilla-inbound/rev/130dbf328dc3

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1b6971da3928
https://hg.mozilla.org/mozilla-central/rev/d06271a6af45
https://hg.mozilla.org/mozilla-central/rev/130dbf328dc3