113696 - Grid alignment not working

Status: NEW

(Core :: XUL, defect)

Description

[Chuck Messenger]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.6) Gecko/20011120
BuildID:    2001112009

If I make a 2-column grid, and want the items in the first column to be
right-aligned, the following should work (according to David Hyatt):

<grid>
    <columns>
        <column pack="end"/>
        <column/>
    </columns>
    <rows>
        <row>
            <description value="cat"/>
            <description value="C"/>
        </row>
        <row>
            <description value="elephant"/>
            <description value="E"/>
        </row>
        <row>
            <description value="fish"/>
            <description value="F"/>
        </row>
    </rows>
</grid>

It doesn't work.

Comment 1

[Chuck Messenger]

Attachment: Shows grid alignment not working

This is a full .xul file demonstrating the problem

Comment 2

[David Hyatt]

Yep, that should have caused the cells in column one to stop stretching and to
right align.

Comment 3

[David Hyatt]

Actually I think this should be align="end" on the column now that I think about
it.  That doesn't work either though, right?

Comment 4

[Chuck Messenger]

Correct -- align="end" didn't work either.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 60529 [details]
Shows grid alignment not working

Changing mimetype of testcase to XUL Mimetype

Comment 6

[Joe Hewitt (gone)]

Moving non nsbeta1+ XUL 1.0 bugs to mozilla1.2

Comment 7

[Christopher Hoess (gone)]

->XUL

Comment 8

[marja]

Attachment: align="stretch" does not seem to work either with grids

This bug is about align="stretch" not stretching so that a column can have a
maxheight with a scrollbar unless user stretches the window and then the column
should stretch too until the scrollbars are not needed anymore. If window is
made smaller part of the scrollbar disappears too.

If I delete maxheight the scrollbar never appears when the windows becomes
smaller.

I have also reported align bug with a button label, it only worked when the
<label> was written out explicitly.

And yes I can confirm this grid align bug too with ff 1.0.1.

I had similar but somewhat different problems with mozilla too but did not test
with the latest version.

Comment 9

[Karsten Düsterloh]

I may be missing something essential here, but the attachment 60529 [details] looks
completely off target to me.
The DOM created by this XUL markup creates the view by laying out *rows* - so to
achieve a specific column width each of the rows elements has to have a specific
width, thus align="end" doesn't make any sense because each element in the first
column has (to have) the same width!
If align="end" should have any impact on such grid columns like here, it should
have to create special cell elements that inherit such aligned and have the
description elements used here as children, maybe by XBL.

Actually, I'd consider the bug as filed to be invalid with regard to the way XUL
works.

Comment 10

[[e-mail]]

FYI, what I have noticed is that align only works on the parent of the element,
whether that be the row or the column, while pack does not work at all.

It would be more useful for align to work both on the row and the column, as you
tend to want to align a column of (say) numbers to the right, while most people
find they want to align rows centrally (which at least already works).