JSNES spends 8% of time in MulValues

NEW
Unassigned

Status

()

Core
JavaScript Engine
3 years ago
3 years ago

People

(Reporter: sstangl, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
We're doing much better than d8, but a profile of the JSNES shell benchmark shows 8% of time spent in the VM multiplying values, which is suspicious.
Is this for a JSOP_POS maybe? It could be the same issue as bug 1131537...
(Reporter)

Comment 2

3 years ago
Yeah, it appears to be for JSOP_POS. The value flowing into the MMul is, e.g. (not in analysis mode):

TypeBarrier(CallGetProperty(Object, "lengthCounter"))

where "lengthCounter" is initialized to null, reset to integer 0, and usually an integer. So although static analysis would tell us that it can be Object null, baseline caches should only see Int32.
(Reporter)

Comment 3

3 years ago
It appears that TI claims to know nothing about these accesses.
(Reporter)

Updated

3 years ago
Depends on: 1131537
I just saw a underscore benchmark that spends 37% of its runtime in MulValues: http://jsperf.com/underscore-indexof-binary/2#chart=bar
Oh this is bug 1131537.
You need to log in before you can comment on or make changes to this bug.