1137026 - [STK] Send TR for SET UP EVENT LIST command from Gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Sean Lee [:seanlee][:weilonge]]

Based on the specification [1]:
"When the ME has successfully accepted or removed the list of events, it shall send TERMINAL RESPONSE (OK) to the SIM. "

Gaia should send the TR for SET UP EVENT LIST because SPRD modem won't handle this.

Reference:
[1] ETSI TS 101 267 - 6.4.16 SET UP EVENT LIST
[2] bug 1132363 comment 28
[3] bug 1132363 comment 30

Comment 1

[jinghua.xing]

Sean：

Thank you for your help. Please handle this on v2.1s branch.

Comment 2

[Sean Lee [:seanlee][:weilonge]]

Attachment: Trail Patch for v2.1s

Hi Jinghua,

Could you help to try the trail patch?
Thank you.

Comment 3

[jinghua.xing]

Sean：

I have test with the patch and it is ok to send TR for SET UP EVENT LIST command.  Thank you.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/STK/v2.1s/Bug1137026 > mozilla-b2g:v2.1s

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Attachment: PR for v2.1s

Hi Fernando,

Could you help to review this patch?
Thank you!

Comment 6

[jinghua.xing]

Sean：

But I wonder if we should change the order of the code and make it send the TR once received the message and then register the event list to avoid the envelope command is sent before the TR.

@@ -42,6 +62,9 @@ var icc_worker = {
   // STK_CMD_SET_UP_EVENT_LIST
   '0x5': function STK_CMD_SET_UP_EVENT_LIST(message) {
     DUMP('STK_CMD_SET_UP_EVENT_LIST:', message.command.options);
+    icc.responseSTKCommand(message, {
+      resultCode: icc._iccManager.STK_RESULT_OK
+    });
     icc_events.register(message, message.command.options.eventList);
   },

Comment 7

[Sean Lee [:seanlee][:weilonge]]

Hi Jinghua,

Based on the specification:
"When the ME has successfully accepted or removed the list of events, it shall send TERMINAL RESPONSE (OK) to the SIM. "

TR should be sent after accepting or removing the list of events successfully.

About envelope command before TR, register() only do event registration then send TR, so any envelope commands will be sent at next tick.

Do you have any suggestions?

Thank you very much.

Comment 8

[jinghua.xing]

Sean：

I am agree with you. Thank you.

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8569602 [details] [review]
PR for v2.1s

Cool ;)

Comment 10

[Sean Lee [:seanlee][:weilonge]]

v2.1s: https://github.com/mozilla-b2g/gaia/commit/a43d64ae01ef108aa4dcc971c770fecd8416a764