1137089 - The sidebar header is white on the developer edition theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Andrei Vaida [:avaida]]

Attachment: screenshot from Ubuntu 14.04 (x64)

Reproducible on:
Aurora 38.0a2 (2015-02-25)

Affected platform:
Ubuntu 14.04 (x64)

Steps to reproduce:
1. Launch Firefox with a clean profile.
2. Enable Reading List by setting 'browser.readinglist.enabled' to true. Restart the browser to apply the pref change.
3. Enable the Reading List sidebar by pressing [CTRL] + [ALT] + [R].
4. Check the styling of the header displayed in the sidebar - (i.e.) the "Reading List" string

Expected result:
The styling of the header is consistent with the Developer Edition theme.

Actual result:
The header's font color is white and almost unnoticeable on the sidebar.

Notes:
- This issue is reproducible only on Linux and it's isolated to Aurora's theme.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

This isn't specific to the ReadingList - it's true for all sidebars (history, bookmarks, etc).

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

And isn't a regression from bug 1123517.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This fixes is it for me, not sure if this breaks anything else though.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8580879 [details] [diff] [review]
patch

Review of attachment 8580879 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a comment explaining why (devedition.css is nice because most of the non-obvious rules have comments about why, and this should too!)

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/fx-team/rev/b65fd368fdb1

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b65fd368fdb1

Comment 7

[Andrei Vaida [:avaida]]

Verified fixed on Aurora 39.0a2 (2015-04-02), using Ubuntu 14.04 (x64), Windows 7 (x64) and Mac OS X 10.9.5.