Closed Bug 1137109 Opened 6 years ago Closed 6 years ago

Tracing "displaylist" maker inside nsViewManager::ProcessPendingUpdates

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: pchang, Assigned: pchang)

References

Details

Attachments

(1 file, 1 obsolete file)

This bug is created based on bug 1127170.

If we move the display list profiler tracing from refresh driver to nsViewManager::ProcessPendingUpdates, then we can capture more use cases related to displaylist processing.

Copy content from bug 1127170 comment 9.

From the profiler in comment 6, the first long transaction loading of homescreen didn't display the 'DisplayList' Marker because this pending update is triggered from [1], not from refresh driver tick function[2].

[1]https://dxr.mozilla.org/mozilla-central/source/view/nsViewManager.cpp#678
[2]https://dxr.mozilla.org/mozilla-central/source/layout/base/nsRefreshDriver.cpp#1708
Blocks: 1127170
BTW, this bug also requires some changes in cleopatra to display the 'displaylist' marker outside refresh driver.
No longer blocks: 1127170
Blocks: 1127170
Assignee: nobody → pchang
Status: NEW → ASSIGNED
Attachment #8569736 - Flags: review?(bgirard)
If I always bypass this checking in [1], I can see the displaylist marker which is not triggered from refresh driver.

I will submit patch for cleopatra later.

[1]https://github.com/bgirard/cleopatra/blob/master/js/parserWorker.js#L2334
Comment on attachment 8569736 [details] [diff] [review]
Move the displaylist tracing inside nsViewManager::ProcessPendingUpdates

Seems reasonable. Passing to :mattwoodrow who knows the code better if it's a good boundary point or not.
Attachment #8569736 - Flags: review?(matt.woodrow)
Attachment #8569736 - Flags: review?(bgirard)
Attachment #8569736 - Flags: review+
Attachment #8569736 - Flags: review?(matt.woodrow) → review+
Remove redundant new line and update reviewers.
Attachment #8569736 - Attachment is obsolete: true
Attachment #8571783 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/d83e46943d92
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.