1137109 - Tracing "displaylist" maker inside nsViewManager::ProcessPendingUpdates

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Peter Chang[:pchang]]

This bug is created based on bug 1127170.

If we move the display list profiler tracing from refresh driver to nsViewManager::ProcessPendingUpdates, then we can capture more use cases related to displaylist processing.

Copy content from bug 1127170 comment 9.

From the profiler in comment 6, the first long transaction loading of homescreen didn't display the 'DisplayList' Marker because this pending update is triggered from [1], not from refresh driver tick function[2].

[1]https://dxr.mozilla.org/mozilla-central/source/view/nsViewManager.cpp#678
[2]https://dxr.mozilla.org/mozilla-central/source/layout/base/nsRefreshDriver.cpp#1708

Comment 1

[Peter Chang[:pchang]]

BTW, this bug also requires some changes in cleopatra to display the 'displaylist' marker outside refresh driver.

Comment 2

[Peter Chang[:pchang]]

Attachment: Move the displaylist tracing inside nsViewManager::ProcessPendingUpdates

Comment 3

[Peter Chang[:pchang]]

If I always bypass this checking in [1], I can see the displaylist marker which is not triggered from refresh driver.

I will submit patch for cleopatra later.

[1]https://github.com/bgirard/cleopatra/blob/master/js/parserWorker.js#L2334

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 8569736 [details] [diff] [review]
Move the displaylist tracing inside nsViewManager::ProcessPendingUpdates

Seems reasonable. Passing to :mattwoodrow who knows the code better if it's a good boundary point or not.

Comment 5

[Peter Chang[:pchang]]

Attachment: Move the displaylist tracing inside nsViewManager::ProcessPendingUpdates

Remove redundant new line and update reviewers.

Comment 6

[Peter Chang[:pchang]]

Build pass for all platform.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7dd912bca62

Comment 7

[Peter Chang[:pchang]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d83e46943d92

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d83e46943d92