1137162 - The regex for TinderboxPrint links should match even when there are spaces in the title/name

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect, P2)

Description

[Ed Morley [:emorley]]

Broken out from bug 1124799 comment 6.

This regex:
RE_LINK_HTML = re.compile(
    (r"((?P<title>[A-Za-z/\.0-9\-_]+): )?"
     r"<a .*href=['\"](?P<url>http(s)?://.+)['\"].*>(?P<value>.+)</a>")
)

Doesn't match:
TinderboxPrint: hazard results: https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64-br-haz/20150226025813

Due to the space in 'hazard results'.

I think it should.

Comment 1

[Ed Morley [:emorley]]

Comment 0 should have referred to RE_LINK_TEXT, but the same issue affects both it and RE_LINK_HTML, so I'll fix both anyway :-)

Comment 2

[Ed Morley [:emorley]]

Attachment: Allow spaces in TinderboxPrint link titles

Comment 3

[Cameron Dawson [:camd]]

Sorry for the delay.  I will review this tomorrow.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/8d156fd9b4edeacab840aac76dad6e0d7eff9a8b
Bug 1137162 - Allow spaces in TinderboxPrint link titles

Currently if a TinderboxPrint line contains a space in the link title,
eg in 'hazard results' here:
TinderboxPrint: hazard results: https://ftp-ssl.mozilla.org/...
...then we ingest it as content_type 'raw_html' rather than 'link'.