Closed
Bug 1137166
Opened 9 years ago
Closed 9 years ago
Change the Content (e10s) moreStrict sandbox pref to an integer to indicate the level of sandboxing.
Categories
(Core :: Security: Process Sandboxing, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
People
(Reporter: bobowen, Assigned: bobowen)
References
Details
Attachments
(1 file)
15.11 KB,
patch
|
TimAbraldes
:
review+
areinald.bug
:
feedback+
|
Details | Diff | Splinter Review |
This is to do a similar change to Bug 1127230, but for the content sandbox.
Updated•9 years ago
|
tracking-e10s:
--- → -
Assignee | ||
Comment 1•9 years ago
|
||
Some sort of start-up problem on tests here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=41c376f8f12a
Assignee | ||
Comment 2•9 years ago
|
||
Finally worked out what was going wrong here. I'd set the initial integrity level to medium and it seems that some of our test machines must be running with auto-elevation and the chrome process is running with high. Which was causing the OpenProcess to fail, because you can't open a process of higher integrity. https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4195c22c4c7
Assignee | ||
Comment 3•9 years ago
|
||
Tim, this gives us a few more levels of sandboxing for people to test with. Andre, I've changed the level pref to be non-platform specific. It was my fault that it was in the first place, which I think was a mistake.
Attachment #8573282 -
Flags: review?(tabraldes)
Attachment #8573282 -
Flags: feedback?(areinald)
Comment 4•9 years ago
|
||
Comment on attachment 8573282 [details] [diff] [review] Change the Content moreStrict sandbox pref to an integer to indicate the level of sandboxing. Technically ok. And I must add that I'm glad with this setting becoming cross-platform as I'll no longer be the only one concerned with having its default value set to 1.
Attachment #8573282 -
Flags: feedback?(areinald) → feedback+
Comment 5•9 years ago
|
||
Comment on attachment 8573282 [details] [diff] [review] Change the Content moreStrict sandbox pref to an integer to indicate the level of sandboxing. Review of attachment 8573282 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me!
Attachment #8573282 -
Flags: review?(tabraldes) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Thanks Tim. remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/972321ec7bcd
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/972321ec7bcd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•