Closed
Bug 1137183
Opened 10 years ago
Closed 10 years ago
Homescreen components visual implementation
Categories
(support.mozilla.org :: BuddyUp, defect)
support.mozilla.org
BuddyUp
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: rik, Assigned: rik)
References
Details
(Whiteboard: p=1 s=bu.2015.5 [blocker] [UI])
Attachments
(2 files)
Page 10
Updated•10 years ago
|
Whiteboard: p=1 [blocker] → p=1 [blocker] [UI]
Updated•10 years ago
|
Whiteboard: p=1 [blocker] [UI] → p=1 s=bu.2015.5 [blocker] [UI]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → anthony
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Helen: In 2.3, you mention titles and subtitles should have a drop shadow of: 0 0 0 3px #000000. I'm not sure what those values refer to. In CSS, we can specify this: <offset-x> <offset-y> <blur-radius> <color>. So one less value than the spec and you can see it doesn't look like your spec in the attached screenshot.
Flags: needinfo?(hhuang)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8581749 -
Flags: review?(rdalal)
Updated•10 years ago
|
Attachment #8581749 -
Flags: review?(rdalal) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://github.com/mozilla/buddyup/commit/5fd23baa8ba4d2adee36d12cf444438a5f74b8dd
Marcia: I'm not sure who should check the home screen.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(mozillamarcia.knous)
Flags: needinfo?(hcondei)
Resolution: --- → FIXED
Comment 4•10 years ago
|
||
I followed a way that the shadow can specify like this: <offset-x> <offset-y> <blur-radius> <spread-radius> <color>, but I can change the value to the way you use, so it will be 0 0 3px #000000 in this case.
One more thing is that I checked the source file and found that only the texts above the image need a drop shadow, but the texts above the blue background doesn't need a shadow, that's why it looks different with the mockups... sorry for the mistake, I have modified the spec.
v 1.9 spec https://bugzilla.mozilla.org/attachment.cgi?id=8582295
Flags: needinfo?(hhuang)
Comment 5•10 years ago
|
||
I verify this as fixed and open bug 1147105 for comment 4.
Status: RESOLVED → VERIFIED
Flags: needinfo?(mozillamarcia.knous)
You need to log in
before you can comment on or make changes to this bug.
Description
•