1137217 - Bottom corners of font panel in reader view should be rounded

Status: RESOLVED DUPLICATE of bug 1142298

(Toolkit :: Reader Mode, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: missing round corners

The corner radius at the bottom of the font panel in reader view should match the one of the top corners.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

It looks like we need to add some bottom radius values.

Let's put the new rules below the:
  #font-type-buttons > li:first-child,
  #font-size-buttons > button:first-child,
  .segmented-button > li:first-child {
rule at https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/aboutReader.css#342 and they should look like:

  .segmented-button > li:first-child {
    border-bottom-left-radius: 4px;
  }

  .segmented-button > li:last-child {
    border-bottom-right-radius: 4px;
  }

Comment 2

[Vikram Jadhav]

I want to work on this bug.
Thanks.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Sounds good.  Do you understand how to show the Font Panel?

Comment 4

[Vikram Jadhav]

Hi,
Actually I dont know about how to show the front panel.
and please tell me how to reproduce the BUG.
Thanks.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Step 1: Go to about:config and make sure "reader.parse-on-load.enabled" is "true".
Step 2: Go to http://www.nytimes.com/2015/03/03/opinion/david-brooks-leaving-and-cleaving.html?_r=0 and wait for it to completely load.
Step 3: Click the icon in the urlbar that looks like a book.
Step 4: Click the "Aa" icon in the bar on the side of the page.

Comment 7

[:Gijs (he/him)]

Unfortunately, this is a duplicate and was already fixed. Vikram, maybe Blake can suggest a different bug you can work on. Blake?

Comment 8

[Blake Winton (:bwinton) (:☕️)]

I believe Vikram and I have been chatting about a different bug, but I admit I forget which one it is.  Perhaps it was bug 995758?