Closed Bug 1137231 Opened 10 years ago Closed 10 years ago

Double Separator In Bookmarks Menu when ReadingList is disabled

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Version:
38 Branch
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 39
Iteration:
39.1 - 9 Mar
Tracking Flags:
Tracking Status
firefox38 --- verified
firefox39 --- verified

People

(Reporter: alice0775, Assigned: Unfocused)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

screenshot
81.59 KB, image/png
Details
Patch v1
3.54 KB, patch
markh
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached image screenshot —
Steps to reproduce: 1. Open Bookmarks Menu (Alt+B)
Blocks: 1124400
Flags: qe-verify+
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Points: --- → 2
Flags: firefox-backlog+
OS: Windows 7 → All
Hardware: x86_64 → All
Summary: Double Separator In Bookmarks Menu → Double Separator In Bookmarks Menu when ReadingList is disabled
Attached patch Patch v1 — — Splinter Review
Attachment #8570247 - Flags: review?(mhammond)
Blocks: 1132074
Iteration: --- → 39.1 - 9 Mar
Comment on attachment 8570247 [details] [diff] [review] Patch v1 Review of attachment 8570247 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/browser-menubar.inc @@ +446,5 @@ > </menu> > #ifndef XP_MACOSX > # Disabled on Mac because we can't fill native menupopups asynchronously > + <menuseparator id="menu_readingListSeparator"> > + <observes element="readingListSidebar" attribute="hidden"/> clever!
Attachment #8570247 - Flags: review?(mhammond) → review+
Comment on attachment 8570247 [details] [diff] [review] Patch v1 Approval Request Comment [Feature/regressing bug #]: bug 1124400 [User impact if declined]: Double separator in bookmarks menu when Readinglist is disabled (default for now) [Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=69aaf2536e35 [Risks and why]: None [String/UUID change made/needed]: None
Attachment #8570247 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/69aaf2536e35
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39: affected → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Attachment #8570247 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Nightly 39.0a1 (2015-03-01) and Aurora 38.0a2 (2015-03-02), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox38: fixed → verified
status-firefox39: fixed → verified
QA Contact: andrei.vaida
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: