Closed Bug 1137259 Opened 5 years ago Closed 5 years ago
Don't send Campaign:Set for downloadable distributions
07:40:12 <@mfinkle> i still think our java code should do better at splitting the distro and campaign 07:40:58 <@mfinkle> imo, propagateMozillaCampaign(referrer) should not be called for a distro ... 07:42:39 <@mfinkle> Campaign:Set creates a JSON file that will try to update the prefs 07:42:52 <@mfinkle> and create a race with the preferences.json shipped with the distro 07:43:14 <@mfinkle> that is the ONLY purpose of propagateMozillaCampaign ... 07:45:04 < rnewman> that's what the campaign message thing is really doing: turning campaigns into distributions so they go via BLP 07:45:30 <@mfinkle> "turning campaigns into distributions so they go via BLP" - right 07:45:47 <@mfinkle> but i don't think we should turn failed distros back into campaigns
Comment on attachment 8569934 [details] [diff] [review] Don't send Campaign:Set for distribution referrer intents. v1 Let's update: https://wiki.mozilla.org/Mobile/Distribution_Files#Crafting_a_distribution_referrer This patch makes utm_source=mozilla mandatory for campaigns and distributions
Attachment #8569934 - Flags: review?(mark.finkle) → review+
ni for uplift.
Karen: the result of this, when it reaches release, is that the experiment you were just trying (using a distribution-esque URL instead of a normal campaign URL) won't be recorded as playstore/distribution.
Comment on attachment 8569934 [details] [diff] [review] Don't send Campaign:Set for distribution referrer intents. v1 This patch changes how Play Store builds handle the referrer intent we're sent after install. The result of the change is that we won't set playstore/distribution for distribution builds that fail to download, or where the distribution isn't found. [Feature/regressing bug #]: N/A [User impact if declined]: N/A [Describe test coverage new/current, TreeHerder]: Distributions have automated tests. Otherwise, effectively untested. [Risks and why]: Low risk. Actually removes a race condition, so generally positive. [String/UUID change made/needed]: None.
Comment on attachment 8569934 [details] [diff] [review] Don't send Campaign:Set for distribution referrer intents. v1 Early in beta still so OK to uplift this and evaluate with the larger population.
You need to log in before you can comment on or make changes to this bug.