Closed
Bug 1137334
Opened 10 years ago
Closed 10 years ago
Remove nsIDOMWindowUtils.getParent
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
4.66 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
It seems to be unused (in that its one caller in our tests is dead code itself), and is one of the few remaining JS_GetParent consumers.
|
Assignee | |
Comment 1•10 years ago
|
||
Bobby, sorry to pick on you, but that test seems like something you should review changes to.
Attachment #8570002 -
Flags: review?(bobbyholley)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8570002 [details] [diff] [review]
Remove nsIDOMWindowUtils.getParent
Review of attachment 8570002 [details] [diff] [review]:
-----------------------------------------------------------------
Huh, so this was totally unused?
Attachment #8570002 -
Flags: review?(bobbyholley) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
As far as I can tell, yes.
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/81589d78bc6f as I grasp at straws to figure out what broke mochitest-e10s-dt today:
https://treeherder.mozilla.org/logviewer.html#?job_id=7050990&repo=mozilla-inbound
Flags: needinfo?(bzbarsky)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Flags: needinfo?(bzbarsky)
|
||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•