1137369 - Slow Addon notification blaming all my addons

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Benoit Girard (:BenWa)]

I just restarted with a recently nightly and it appears that bug 1071880 blamed all my addons one by one. I checked my jrmuizel/mstange and they've also seen a lot of false positives from this feature.

I think the thresholds may need to be tweaked.

For me it listed 'Firefox Developer Tools Adapters', 'Gecko Profiler', 'Gmail Notifier (restartless)', (and more I think), from the same restart.

My restart felt fast but I wasn't timing it.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: Startup simple measure

Here's the about:telemetry measure of my startup time FWIW.

Here I'm assuming that my addons didn't do any real work after 'sessionRestored'. With that assumption in 1500ms (my startup time) we couldn't of had more than 2 addons do enough work before 'sessionRestored' to be blamed (using 750ms of time).

There might be double counting going on here or some accounting bug.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Benoit Girard (:BenWa) from comment #1)
> Created attachment 8570057 [details]
> Startup simple measure
> 
> Here's the about:telemetry measure of my startup time FWIW.
> 
> Here I'm assuming that my addons didn't do any real work after
> 'sessionRestored'. With that assumption in 1500ms (my startup time) we
> couldn't of had more than 2 addons do enough work before 'sessionRestored'
> to be blamed (using 750ms of time).
I question that assumption.

> There might be double counting going on here or some accounting bug.
There is a bug related to that. Bug 674779 should have resolved that and landed yesterday. Can you retest with tomorrow's nightly?

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Note that users are reporting this as well with all addons in nightly (and with e10s disabled):

  https://twitter.com/meyerweb/status/573939603167559681

Comment 4

[Benoit Girard (:BenWa)]

I haven't seen this in the last 3 months. I'll keep an eye out but I'm calling to close this as WFM now.

Please re-open if those other users are still reporting it.

Comment 5

[pabloalmeidaff9]

Still being seen on 43.0a1 (2015-08-17). I have a content add-on that runs on only one page and I get the warning when I start Nightly without going to the page.