Add support for installing/uninstalling Firefox installers via mozinstall

RESOLVED FIXED in mozilla39

Status

Testing
Firefox UI Tests
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

53 bytes, text/x-github-pull-request
chmanchester
: review+
chmanchester
: feedback+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
We need support in our harness to install and uninstall Firefox builds from the appropriate installers. David, what would be the best class in Marionette to subclass for that enhancement? Once I know that I can give more details in what is necessary to do.
(Assignee)

Updated

3 years ago
Flags: needinfo?(dburns)
(Assignee)

Comment 2

3 years ago
Thanks David! So what we would have to do here is the following:

* Add additional checks for the binary if it is an installer [mozinstall.is_installer()] before the option reaches the code in BaseMarionetteTestRunner.

* If it is not an installer pass-through the binary option

* If it is an installer, call mozinstall.install() and force the returned path as new binary for BaseMarionetteTestRunner. Also set a flag that Firefox got installed.

* Run the tests as usual

* Check if the install flag is set. If yes, call mozinstall.uninstall() for that installed Firefox, so it's getting removed.


I'm cc'ing Bob here just in case he wants to work on something else beside the software-update and about window lib, and I would get to it.
(Assignee)

Updated

3 years ago
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Created attachment 8573226 [details] [review]
github_pull_request.txt

The proposed solution from IRC is indeed working pretty well! This referenced PR adds support for mozinstall to our harness, and also let Travis CI use it.
Attachment #8573226 - Flags: review?(cmanchester)
Comment on attachment 8573226 [details] [review]
github_pull_request.txt

I left a few comments/questions I'd like to resolve before landing, but this is a straightforward change and is pretty much good to go.
Attachment #8573226 - Flags: review?(cmanchester) → feedback+
(Assignee)

Comment 5

3 years ago
Comment on attachment 8573226 [details] [review]
github_pull_request.txt

Did the changes. I hope now it looks like what you wanted to have with --installer?
Attachment #8573226 - Flags: review?(cmanchester)
Attachment #8573226 - Flags: review?(cmanchester) → review+
(Assignee)

Comment 6

3 years ago
PR got merged as:
https://github.com/mozilla/firefox-ui-tests/commit/e09f45926c82081fd23112c1459077230afa0975

At some point we have to think about unit tests for our harness. I will file a new bug for it so we can collect the first ideas.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
(Assignee)

Updated

3 years ago
Priority: -- → P1
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.