1137396 - Add support for installing/uninstalling Firefox installers via mozinstall

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We need support in our harness to install and uninstall Firefox builds from the appropriate installers. David, what would be the best class in Marionette to subclass for that enhancement? Once I know that I can give more details in what is necessary to do.

Comment 1

[David Burns :automatedtester]

Looks like you use BaseMarionetteTestRunner http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runtests.py#12

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks David! So what we would have to do here is the following:

* Add additional checks for the binary if it is an installer [mozinstall.is_installer()] before the option reaches the code in BaseMarionetteTestRunner.

* If it is not an installer pass-through the binary option

* If it is an installer, call mozinstall.install() and force the returned path as new binary for BaseMarionetteTestRunner. Also set a flag that Firefox got installed.

* Run the tests as usual

* Check if the install flag is set. If yes, call mozinstall.uninstall() for that installed Firefox, so it's getting removed.


I'm cc'ing Bob here just in case he wants to work on something else beside the software-update and about window lib, and I would get to it.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: github_pull_request.txt

The proposed solution from IRC is indeed working pretty well! This referenced PR adds support for mozinstall to our harness, and also let Travis CI use it.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8573226 [details] [review]
github_pull_request.txt

I left a few comments/questions I'd like to resolve before landing, but this is a straightforward change and is pretty much good to go.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8573226 [details] [review]
github_pull_request.txt

Did the changes. I hope now it looks like what you wanted to have with --installer?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

PR got merged as:
https://github.com/mozilla/firefox-ui-tests/commit/e09f45926c82081fd23112c1459077230afa0975

At some point we have to think about unit tests for our harness. I will file a new bug for it so we can collect the first ideas.