If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[EME] build failure in gmp-clearkey in non-unified builds

RESOLVED FIXED in Firefox 37

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla39
x86_64
Windows 8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox37 fixed, firefox38 fixed, firefox39 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
With unified builds disabled on Windows I see a build failure in gmp-clearkey:

11:14.47 base_switches.cc
11:14.47 ClearKeySessionManager.cpp
11:14.47 c:/Users/cpearce/src/mozilla/central/media/gmp-clearkey/0.1/ClearKeySessionManager.cpp(43) : error C2653: 'wmf' : is not a class or namespace name
11:14.48 c:/Users/cpearce/src/mozilla/central/media/gmp-clearkey/0.1/ClearKeySessionManager.cpp(43) : error C3861: 'EnsureLibs': identifier not found
11:14.48
11:14.49 In the directory  /c/Users/cpearce/src/mozilla/central/objdir/media/gmp-clearkey/0.1
11:14.50 The following command failed to execute properly:
11:14.50 c:/Users/cpearce/src/mozilla/central/objdir/_virtualenv/Scripts/python.exe -m mozbuild.action.cl cl -FoClearKeySessionManager.obj -c -DENABLE_WMF -DMOZ_NO_MOZALLOC -DAB_CD=en-US -DNO_NSPR_10_
SUPPORT -Ic:/Users/cpearce/src/mozilla/central/media/gmp-clearkey/0.1 -I. -Ic:/Users/cpearce/src/mozilla/central/dom/media/gmp -I../../../dist/include -Ic:/Users/cpearce/src/mozilla/central/objdir/dis
t/include/nspr -Ic:/Users/cpearce/src/mozilla/central/objdir/dist/include/nss -MT -FI ../../../dist/include/mozilla-config.h -DMOZILLA_CLIENT -TP -nologo -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:IA32 -FS -wd
4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR- -DDEBUG -DTRACING -Zi -Oy- -Fdgenerated.pdb c:/Users/cpearce/src/mozilla/central/media/gmp-clearkey/0.1/ClearKeySessionManager
.cpp
11:14.50 cpu.obj
(Assignee)

Comment 1

3 years ago
Created attachment 8570694 [details] [diff] [review]
Patch
Attachment #8570694 - Flags: review?(edwin)
Attachment #8570694 - Flags: review?(edwin) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c41d373af29
(Assignee)

Comment 3

3 years ago
Must uplift...
Flags: needinfo?(cpearce)
https://hg.mozilla.org/mozilla-central/rev/0c41d373af29
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/d56acccf3b69
status-firefox37: --- → fixed
(Assignee)

Comment 6

3 years ago
Created attachment 8572383 [details] [diff] [review]
Beta patch

Patch for beta branch as part of EME platform uplift.
(Assignee)

Comment 7

3 years ago
Comment on attachment 8572383 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.
Attachment #8572383 - Flags: approval-mozilla-beta?
(Assignee)

Updated

3 years ago
status-firefox38: --- → affected
Flags: needinfo?(cpearce)
(Assignee)

Comment 8

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/1fff78b318d6
status-firefox38: affected → fixed
Comment on attachment 8572383 [details] [diff] [review]
Beta patch

Approved for Beta and Aurora as part of EME platform uplift.
Attachment #8572383 - Flags: approval-mozilla-beta?
Attachment #8572383 - Flags: approval-mozilla-beta+
Attachment #8572383 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.