1137529 - Attempt to use VDA for high-definition video

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

Apple's VideoToolbox performance can be sub-par on some machines, even when hardware acceleration is in use.

Yet, VDA is always super fast.

So use it for high-def when possible as a temporary work-around.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Prefer Apple's VDA hardware acceleration for Hi-Def videos

Try VDA first if the resolution height is >= 720p. Not a perfect test, but seeing the problem is mostly an issue on 1080p and 4K video, 720p will do. Also change so media.apple.forcevda can be changed on the fly. I didn't know about Preferences::AddBoolVarCache when I first wrote that code.

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8570328 [details] [diff] [review]
Prefer Apple's VDA hardware acceleration for Hi-Def videos

Review of attachment 8570328 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.

Comment 3

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c6e173b28eca

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c6e173b28eca

Comment 5

[Ralph Giles (:rillian)]

This seems to have helped on my Early 2013 MacBook. Yesterday's nightly and today's dev edition dropped many frames playing the longboard video https://www.youtube.com/watch?v=79ImZE0K7xc at 1080p60. With today's nightly it's quite smooth.

However, I still get most frames dropping on https://www.youtube.com/watch?v=-6xgKbQN1KA

Comment 6

[Jean-Yves Avenard [:jya]]

Attachment: Partial evert of commit c6e173b28eca

partial revert of c6e173b28eca

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8590657 [details] [diff] [review]
Partial evert of commit c6e173b28eca

Review of attachment 8590657 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with commit message changed to:

Bug 1137529: Don't prefer VDA for 720p and above. r=rillian

Partially reverts the prior change.

Comment 8

[Jean-Yves Avenard [:jya]]

Comment on attachment 8590657 [details] [diff] [review]
Partial evert of commit c6e173b28eca

Wrong bug#