1137532 - error: 'AssertOnDispatchThread' marked 'override' but does not override any member functions : need to update clang on OSX64

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

On our OSX64 Debug build, we're red due to:
/usr/local/bin/ccache /builds/slave/c-cen-t-osx64-dbg/build/clang/bin/clang++ -o nsTypeAheadFind.o -c  -fvisibility=hidden -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-osx64-dbg/build/mozilla/toolkit/components/typeaheadfind -I.  -I../../../dist/include   -I/builds/slave/c-cen-t-osx64-dbg/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-osx64-dbg/build/objdir/dist/include/nss       -fPIC  -Qunused-arguments  -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsTypeAheadFind.o.pp -Qunused-arguments  -Qunused-arguments -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wno-c++0x-extensions -Wno-extended-offsetof -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -DNO_X11 -pipe  -DDEBUG -DTRACING -gdwarf-2 -O3 -fno-omit-frame-pointer       /builds/slave/c-cen-t-osx64-dbg/build/mozilla/toolkit/components/typeaheadfind/nsTypeAheadFind.cpp
In file included from Unified_cpp_layout_generic3.cpp:29:
In file included from ../../../mozilla/layout/generic/nsVideoFrame.cpp:14:
In file included from ../../dist/include/mozilla/dom/HTMLVideoElement.h:11:
In file included from ../../dist/include/mozilla/dom/HTMLMediaElement.h:22:
In file included from ../../dist/include/MediaDecoder.h:200:
In file included from ../../dist/include/mozilla/CDMProxy.h:16:
In file included from ../../dist/include/mozilla/CDMCaps.h:16:
In file included from ../../dist/include/SamplesWaitingForKey.h:11:
In file included from ../../dist/include/MediaTaskQueue.h:15:
../../dist/include/MediaPromise.h:257:16: error: 'AssertOnDispatchThread' marked 'override' but does not override any member functions
  virtual void AssertOnDispatchThread() MOZ_OVERRIDE
               ^
1 error generated.
make[4]: *** [Unified_cpp_layout_generic3.o] Error 1
make[3]: *** [layout/generic/target] Error 2
make[3]: *** Waiting for unfinished jobs....

This was from http://hg.mozilla.org/mozilla-central/rev/6a393700a62d

We need to upgrade our clang compiler on our OSX64 via tooltool manifest.

Comment 1

[Edmund Wong (:ewong)]

Attachment: patch #1 (v1)

Looking at m-c's releng.manifest, do we also need the sccache.tar.gz and
change the info with the setup.sh?

Comment 2

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #1)
> Created attachment 8570245 [details] [diff] [review]
> proposed patch (v1)
> 
> Looking at m-c's releng.manifest, do we also need the sccache.tar.gz and
> change the info with the setup.sh?

From IRC, Callek said no.

Also post-push review.

Comment 3

[Edmund Wong (:ewong)]

Comment on attachment 8570245 [details] [diff] [review]
patch #1 (v1)

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/9f9a344d0f24

Comment 4

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #3)
> Comment on attachment 8570245 [details] [diff] [review]
> proposed patch (v1)
> 
> [Approval Request Comment]
> Regression caused by (bug #): bug 1128576
> User impact if declined: bustage due to missing correct clang version
> Testing completed (on m-c, etc.): 
> Risk to taking this patch (and alternatives if risky):
> String changes made by this patch:
>

Comment 5

[Edmund Wong (:ewong)]

Comment on attachment 8570245 [details] [diff] [review]
patch #1 (v1)

Backed out.

https://hg.mozilla.org/comm-central/rev/9585100af07d

Comment 6

[Edmund Wong (:ewong)]

Attachment: patch #2 (v2)

for post push review

Comment 7

[Edmund Wong (:ewong)]

Comment on attachment 8571719 [details] [diff] [review]
patch #2 (v2)

Push to comm-central:
 https://hg.mozilla.org/comm-central/rev/2074af946874

Comment 8

[Edmund Wong (:ewong)]

Comment on attachment 8570245 [details] [diff] [review]
patch #1 (v1)

This patch is also needed on top of the proposed patch (v2).

Comment 9

[Edmund Wong (:ewong)]

Comment on attachment 8570245 [details] [diff] [review]
patch #1 (v1)

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/d5da9c0cd114

Comment 10

[Edmund Wong (:ewong)]

Comment on attachment 8570245 [details] [diff] [review]
patch #1 (v1)

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: bustage in osx64 builds. (needs patch 2) as well.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 11

[Edmund Wong (:ewong)]

Comment on attachment 8571719 [details] [diff] [review]
patch #2 (v2)

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: osx64 build bustage.  (need patch 1)
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 12

[Justin Wood (:Callek)]

Comment on attachment 8570245 [details] [diff] [review]
patch #1 (v1)

Review of attachment 8570245 [details] [diff] [review]:
-----------------------------------------------------------------

a+ for aurora based on results from central.

Comment 13

[Justin Wood (:Callek)]

Comment on attachment 8571719 [details] [diff] [review]
patch #2 (v2)

Review of attachment 8571719 [details] [diff] [review]:
-----------------------------------------------------------------

a+ for aurora based on results from central.

Comment 14

[Edmund Wong (:ewong)]

Pushed to comm-aurora:
https://hg.mozilla.org/releases/comm-aurora/rev/2e33f6e8e9fc
https://hg.mozilla.org/releases/comm-aurora/rev/9949eb965990