1137536 - Split DeferredFinalize out of nsCycleCollector.h into its own file

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Move DeferredFinalize out of the cyclecollector namespace.

DeferredFinalize is really more about JS that holds onto C++ than about the CC in particular.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eac7c6e48d71

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Make sure every file that uses an nsCycleCollector_ function includes nsCycleCollector.h.

This will let us remove it from headers after we split out DeferredFinalize into its own header.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Move the top level DeferredFinalize functions into their own file.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8577619 [details] [diff] [review]
part 1 - Move DeferredFinalize out of the cyclecollector namespace.

I wonder why this stuff was ever in cyclecollector namespace.

Comment 5

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae02f2179c4c
https://hg.mozilla.org/integration/mozilla-inbound/rev/6583592e42eb
https://hg.mozilla.org/integration/mozilla-inbound/rev/62bc2ec66948

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ae02f2179c4c
https://hg.mozilla.org/mozilla-central/rev/6583592e42eb
https://hg.mozilla.org/mozilla-central/rev/62bc2ec66948