Closed
Bug 1137707
Opened 9 years ago
Closed 9 years ago
Use localStorage in fireplace UI tests
Categories
(Marketplace Graveyard :: Code Quality, defect, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
We currently disable localStorage for some modules in the fireplace UI tests. If this is not disabled it causes some tests to fail in tests/ui/app_list.js and tests/ui/installs.js. We use localStorage in production so we should be testing with it. Let's remove `capabilities.phantom` from marketplace-core-modules and fireplace, clear localStorage when tests start and fix the failing tests.
Assignee | ||
Comment 1•9 years ago
|
||
Looks like the tests actually pass if we clear on `page.initialized` instead of after `casper.open` or in setup/teardown.
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
https://github.com/mstriemer/fireplace/commit/27156bbfcd65878f55303bc4d5d13f2dd77e04e1 https://github.com/mozilla/marketplace-core-modules/commit/46b9289492a4fb895f72d7a7130cd8b7c4ec60b4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•