1137799 - AutoConfig files are not loaded as UTF-8

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Mike Kaply [:mkaply]]

I have no idea how this has been around so long.

If you have an AutoConfig file that looks like this;

//
Components.utils.reportError("é");

You get

é

on the console.

The AutoConfig file is not being loaded as UTF-8

Comment 1

[Mike Kaply [:mkaply]]

Relevant code is here.

http://mxr.mozilla.org/mozilla-central/source/extensions/pref/autoconfig/src/nsReadConfig.cpp#234

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Very simple fix for problem.

Very simple fix. We were assuming the file was ASCII.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8589778 [details] [diff] [review]
Very simple fix for problem.

No idea who owns this stuff these days but this change seems sane enough

Comment 4

[Mike Kaply [:mkaply]]

[Tracking Requested - why for this release]:

Sorry for the lateness in the cycle, but I'd really like this for the Firefox 38 if possible, primarily because of the ESR.

As we move forward in encouraging people to use AutoConfig (instead of distribution/bundles), we'll need i18n to work correctly. In addition, it allows me to remove some hacks in the CCK2.

This is very low risk and only affects AutoConfig.

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd23898c54d1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dd23898c54d1

Comment 6

[Kate Glazko]

Hi Mike, it has been a while since this bug has been touched. It has missed multiple ESR releases. Are you alright with it being untracked for ESR?

Comment 7

[Mike Kaply [:mkaply]]

Yes, we'll just let it ride the train.