1137957 - Unified build failure in GMPVideoDecoder

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

With unified builds disabled, I get this error:

 0:12.50 Note: rebuild with "c:/mozilla-build/mozmake/mozmake.EXE VERBOSE=1 all-local" to show all compiler parameters.
 0:13.20 MediaDataDecoderProxy.cpp
 0:13.49 GMPVideoDecoder.cpp
 0:13.49 c:\users\cpearce\src\mozilla\beta\objdir\dist\include\nsTArray.h(439) : error C2129: static function 'bool mozilla::IsOnGMPThread(void)' declared but not defined
 0:13.49         c:/Users/cpearce/src/mozilla/beta/dom/media/fmp4/gmp/GMPVideoDecoder.cpp(14) : see declaration of 'mozilla::IsOnGMPThread'
 0:13.50
 0:13.50 In the directory  /c/Users/cpearce/src/mozilla/beta/objdir/dom/media/fmp4/gmp

This also happens in my EME uplift patch queue on Try, without unified disabled.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ca0b29f0eca

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Must uplift...

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ca0b29f0eca

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a7098648876a

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Beta patch

Patch for beta branch as part of EME platform uplift.

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572385 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fe65513db838

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572385 [details] [diff] [review]
Beta patch

Approved for Beta and Aurora as part of EME platform uplift.