Closed
Bug 1138094
Opened 7 years ago
Closed 7 years ago
Fix in-tree consumers that use non-standard flag argument of String.prototype.{search,match,replace} in im/.
Categories
(Instantbird :: Other, defect)
Instantbird
Other
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
3.28 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
(same as bug 1131107) Before fixing bug 1108382, we need to replace all of them with regexp literal, new RegExp(...) or .split().join().
|
Assignee | |
Comment 1•7 years ago
|
||
Fixed String.prototype.replace call sites to use regexp literals. at least no regression on try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7a729c78766a
Attachment #8570974 -
Flags: review?(florian)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8570974 [details] [diff] [review] Do not use non-standard flag argument of String.prototype.replace in im/. Review of attachment 8570974 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8570974 -
Flags: review?(florian) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Thank you :D https://hg.mozilla.org/comm-central/rev/513b765eb104
Assignee: nobody → arai.unmht
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•