1138096 - Fix in-tree consumers that use non-standard flag argument of String.prototype.{search,match,replace} in mailnews/db/.

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Tooru Fujisawa [:arai]]

(same as bug 1131107)

Before fixing bug 1108382, we need to replace all of them with regexp literal, new RegExp(...) or .split().join().

Comment 1

[:aceman]

Hi, thanks for filing this to make us aware of the changes. Where can we find description of which arguments are considered non-stanadard? Bug 1108382 is especially empty, bug 1131107 is better.

Comment 2

[Tooru Fujisawa [:arai]]

3rd argument of String.prototype.replace, and 2nd argument of String.prototype.match/search.
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace
  (no description for match/search on MDN though)

I already prepared patch series for all of them, and now testing :)

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Do not use non-standard flag argument of String.prototype.replace in mailnews/db/.

Fixed String.prototype.replace call sites. Used .split().join() if pattern is variable, and used regexp literals for other cases.

at least no regression on try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7a729c78766a

Comment 4

[Kent James (:rkent)]

Comment on attachment 8570976 [details] [diff] [review]
Do not use non-standard flag argument of String.prototype.replace in mailnews/db/.

I'll look at this.

Comment 5

[Kent James (:rkent)]

Comment on attachment 8570976 [details] [diff] [review]
Do not use non-standard flag argument of String.prototype.replace in mailnews/db/.

Review of attachment 8570976 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks for thinking of comm-central!

Comment 6

[Tooru Fujisawa [:arai]]

Thank you for reviewing! :D

https://hg.mozilla.org/comm-central/rev/23e852deb53d