Closed
Bug 1138098
Opened 9 years ago
Closed 9 years ago
Fix in-tree consumers that use non-standard flag argument of String.prototype.{search,match,replace} in mailnews/test/.
Categories
(MailNews Core :: Testing Infrastructure, defect)
MailNews Core
Testing Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 39.0
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
2.25 KB,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
(same as bug 1131107) Before fixing bug 1108382, we need to replace all of them with regexp literal, new RegExp(...) or .split().join().
|
Assignee | |
Comment 1•9 years ago
|
||
Fixed String.prototype.replace call sites to use regexp literals. at least no regression on try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7a729c78766a
Attachment #8570978 -
Flags: review?(Pidgeot18)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8570978 [details] [diff] [review] Do not use non-standard flag argument of String.prototype.replace in mailnews/test/. Review of attachment 8570978 [details] [diff] [review]: ----------------------------------------------------------------- Can't say if you've missed any, but this patch WFM.
Attachment #8570978 -
Flags: review?(Pidgeot18) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Thank you! :D https://hg.mozilla.org/comm-central/rev/01aa78e6ea74
Assignee: nobody → arai.unmht
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0
You need to log in
before you can comment on or make changes to this bug.
Description
•