1138099 - Fix in-tree consumers that use non-standard flag argument of String.prototype.{search,match,replace} in suite/.

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Tooru Fujisawa [:arai]]

(same as bug 1131107)

Before fixing bug 1108382, we need to replace all of them with regexp literal, new RegExp(...) or .split().join().

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Do not use non-standard flag argument of String.prototype.replace in suite/.

> -    let hosts = Object.keys(cookieHosts).join("|").replace("\\.", "\\.", "g");
> +    let hosts = Object.keys(cookieHosts).join("|").replace(/\./g, "\\.");

I think this is same issue as bug 1131107 comment #23, pre-existing bug that it does not replace anything, but it should replace "." with BACKSLASH+"."
Applied same change as mozilla-central.

at least no regression on try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7a729c78766a

Comment 2

[Edmund Wong (:ewong)]

(In reply to Tooru Fujisawa [:arai] from comment #1)
> Created attachment 8570979 [details] [diff] [review]
> Do not use non-standard flag argument of String.prototype.replace in suite/.
> 
> > -    let hosts = Object.keys(cookieHosts).join("|").replace("\\.", "\\.", "g");
> > +    let hosts = Object.keys(cookieHosts).join("|").replace(/\./g, "\\.");
> 
> I think this is same issue as bug 1131107 comment #23, pre-existing bug that
> it does not replace anything, but it should replace "." with BACKSLASH+"."
> Applied same change as mozilla-central.
> 
> at least no regression on try run:
> https://treeherder.mozilla.org/#/jobs?repo=try-comm-
> central&revision=7a729c78766a

fwiw, try-comm-central only do tests against mail/ code.  suite/ code
changes, while applied to the try-tree, are not tested (and iirc, 
not even built by default.)  Testing against suite/ will require a 
.mozconfig change also  (just saying)

Comment 3

[Tooru Fujisawa [:arai]]

Thank you for reviewing!

Is it required to run try with .mozconfig change?
If so, is there any example for the change?

Comment 4

[Edmund Wong (:ewong)]

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/94a6184a5646

Comment 5

[Edmund Wong (:ewong)]

Thanks for the patch :arai!