113810 - nsFramemanager.cpp warnings make the layout regression tests a real pain

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Bernd]

David, your checking for bug 110911 has caused a regression. I cant load any
page without a bunch of warnings:"already have a primary frame for content".
Tinderbox shows the same under linux.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

They're just WARNINGs, i.e., things that print on the console.  They shouldn't
bring up dialogs or anything, and they are something that should be
investigated, which is why I put them in.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

How do they make the regression tests a pain?

Comment 3

[Bernd]

Attachment: logfile

I think that logfile looks somehow cluttered.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Index: nsFrameManager.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/base/src/nsFrameManager.cpp,v
retrieving revision 1.94
diff -u -d -r1.94 nsFrameManager.cpp
--- nsFrameManager.cpp	6 Dec 2001 05:45:01 -0000	1.94
+++ nsFrameManager.cpp	6 Dec 2001 19:51:19 -0000
@@ -694,7 +694,7 @@
     // Add a mapping to the hash table
     PrimaryFrameMapEntry *entry = NS_STATIC_CAST(PrimaryFrameMapEntry*,
         PL_DHashTableOperate(&mPrimaryFrameMap, aContent, PL_DHASH_ADD));
-#ifdef DEBUG
+#ifdef DEBUG_dbaron
     if (entry->frame) {
       NS_WARNING("already have primary frame for content");
     }

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed.  Now only I will see warnings about how messed up our frame construction
code is.