Closed
Bug 1138127
Opened 10 years ago
Closed 10 years ago
[email] Very first launch results in missing "fullyLoaded" metric for test-perf
Categories
(Firefox OS Graveyard :: Gaia::E-Mail, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jrburke, Assigned: jrburke)
References
Details
Attachments
(1 file)
Due to the changes in bug 1128739, for the very first launch, when there is no cache set up at all, the model module is loaded, and it does an `evt.emit('metrics:apiDone');`. However, at this point, some modules are not loaded, specifically the metrics module, so that emit evaporates into the air. The call should really be `evt.emitWhenListener('metrics:apiDone');` now. Working up a patch now. This only happens on the very first, no cache launch when hasAccount in the cache has not been populated. Tested with `test-perf` and it works with this change.
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8570989 -
Flags: review?(bugmail)
Updated•10 years ago
|
Attachment #8570989 -
Flags: review?(bugmail) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 2•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f792f897656777f306a2972c4cc5efce15b3b950
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•