[email] Very first launch results in missing "fullyLoaded" metric for test-perf

RESOLVED FIXED

Status

Firefox OS
Gaia::E-Mail
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jrburke, Assigned: jrburke)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Due to the changes in bug 1128739, for the very first launch, when there is no cache set up at all, the model module is loaded, and it does an `evt.emit('metrics:apiDone');`.

However, at this point, some modules are not loaded, specifically the metrics module, so that emit evaporates into the air.

The call should really be `evt.emitWhenListener('metrics:apiDone');` now. Working up a patch now.

This only happens on the very first, no cache launch when hasAccount in the cache has not been populated. Tested with `test-perf` and it works with this change.
Created attachment 8570989 [details] [review]
[gaia] jrburke:bug1138127-email-metric-emit > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8570989 - Flags: review?(bugmail)
Attachment #8570989 - Flags: review?(bugmail) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f792f897656777f306a2972c4cc5efce15b3b950

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.