Long-tapping black area of software home button triggers homescreen context menu

VERIFIED FIXED in 2.2 S7 (6mar)

Status

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: gerard-majax, Assigned: etienne)

Tracking

({polish, regression})

unspecified
2.2 S7 (6mar)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

On shinano and aries devices, at least.

STR:
 0. On a device without hardware home button, software home button enabled
 1. Scroll to the bottom of homescreen
 2. Long-press on the black zone of software home button

Expected:
 Nothing happens

Actual:
 Homescreen context menu is triggered
Flags: needinfo?(mhenretty)
blocking-b2g: --- → 2.2?
Flags: needinfo?(mhenretty)
Whiteboard: [systemsfe]
regression
blocking-b2g: 2.2? → 2.2+
Keywords: regression
Component: Gaia::System::Input Mgmt → Gaia::System::Window Mgmt
Assignee: nobody → gmarty
Assignee: gmarty → nobody
Assignee

Updated

4 years ago
Assignee: nobody → etienne
Assignee

Comment 3

4 years ago
Comment on attachment 8572715 [details] [review]
[gaia] etiennesegonzac:bug-1138147 > mozilla-b2g:master

This is a fuzzing issue.

I also switched from border to outline for the SHB in order to make it a bigger tap target since it was kinda depending on events being fuzzed to work before.
Attachment #8572715 - Flags: review?(gmarty)
Comment on attachment 8572715 [details] [review]
[gaia] etiennesegonzac:bug-1138147 > mozilla-b2g:master

Looks good to me with a couple of nits left in Github.
Attachment #8572715 - Flags: review?(gmarty) → review+
Assignee

Updated

4 years ago
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Please request Gaia v2.2 approval on this patch when you get a chance.
Flags: needinfo?(etienne)
Target Milestone: --- → 2.2 S7 (6mar)
Assignee

Comment 7

4 years ago
Comment on attachment 8572715 [details] [review]
[gaia] etiennesegonzac:bug-1138147 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): initial SHB support
[User impact] if declined: see Description (not a blocking scenario)
[Testing completed]: SHB scenarios in landscape and portrait orientation
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]:none
Flags: needinfo?(etienne)
Attachment #8572715 - Flags: approval-gaia-v2.2?
Summary: Long-taping black area of software home button triggers homescreen context menu → Long-tapping black area of software home button triggers homescreen context menu
Reporter

Comment 8

4 years ago
While this is fixing the issue, I have noticed that since it landed on master, I sometimes do have a hard time properly tapping the home button. One case it happened me quite easily was when browsing pages.
Assignee

Updated

4 years ago
Depends on: 1142162
Attachment #8572715 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
This issue is verified fixed in the latest Nightly Flame 3.0 and 2.2 builds.

Actual Results: Long tapping the black bar around the software homebutton does not bring up a context menu when on the homescreen.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150324010202
Gaia: efebbafd12fc42ddcd378948b683a51106517660
Gecko: 840cfd5bc971
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150324002504
Gaia: 014d38f7ad3912b8b33cb08ce7535a5dc5aced59
Gecko: 7a9f2a248e57
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: verifyme
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.