1138147 - Long-tapping black area of software home button triggers homescreen context menu

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[:gerard-majax]

On shinano and aries devices, at least.

STR:
 0. On a device without hardware home button, software home button enabled
 1. Scroll to the bottom of homescreen
 2. Long-press on the black zone of software home button

Expected:
 Nothing happens

Actual:
 Homescreen context menu is triggered

Comment 1

[Gregor Wagner [:gwagner]]

regression

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1138147 > mozilla-b2g:master

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8572715 [details] [review]
[gaia] etiennesegonzac:bug-1138147 > mozilla-b2g:master

This is a fuzzing issue.

I also switched from border to outline for the SHB in order to make it a bigger tap target since it was kinda depending on events being fuzzed to work before.

Comment 4

[Guillaume Marty [:gmarty]]

Comment on attachment 8572715 [details] [review]
[gaia] etiennesegonzac:bug-1138147 > mozilla-b2g:master

Looks good to me with a couple of nits left in Github.

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/1eb4d4e0a3a3f0ccaa60c98b3e89019092d03290

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 approval on this patch when you get a chance.

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8572715 [details] [review]
[gaia] etiennesegonzac:bug-1138147 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): initial SHB support
[User impact] if declined: see Description (not a blocking scenario)
[Testing completed]: SHB scenarios in landscape and portrait orientation
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]:none

Comment 8

[:gerard-majax]

While this is fixing the issue, I have noticed that since it landed on master, I sometimes do have a hard time properly tapping the home button. One case it happened me quite easily was when browsing pages.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/02e2d06e2ee49a137493b4434953049e436087dc

Comment 10

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed in the latest Nightly Flame 3.0 and 2.2 builds.

Actual Results: Long tapping the black bar around the software homebutton does not bring up a context menu when on the homescreen.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150324010202
Gaia: efebbafd12fc42ddcd378948b683a51106517660
Gecko: 840cfd5bc971
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150324002504
Gaia: 014d38f7ad3912b8b33cb08ce7535a5dc5aced59
Gecko: 7a9f2a248e57
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0