Should GetOutputStreamInfo() be called after IMFTransform::SetOutputType()/MF_E_TRANSFORM_STREAM_CHANGE

RESOLVED FIXED in Firefox 37

Status

()

Core
Audio/Video
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

Trunk
mozilla39
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox37+ fixed, firefox38+ fixed, firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Referring to MFT_OUTPUT_STREAM_PROVIDES_SAMPLES
"These flags remain constant unless the media type for the output stream changes."

https://msdn.microsoft.com/en-us/library/windows/desktop/ms704014%28v=vs.85%29.aspx
(Assignee)

Comment 1

3 years ago
Created attachment 8571088 [details] [diff] [review]
GetOutputStreamInfo() after each SetOutputType()

https://treeherder.mozilla.org/#/jobs?repo=try&revision=325489057c48
Attachment #8571088 - Flags: review?(cpearce)
(Assignee)

Comment 2

3 years ago
I wonder whether this may be related to some of the hangs in bug 1129455.
Perhaps there's a remote chance.
Blocks: 1129455
Attachment #8571088 - Flags: review?(cpearce) → review+

Updated

3 years ago
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/6bd19f34057f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
(Assignee)

Comment 5

3 years ago
Comment on attachment 8571088 [details] [diff] [review]
GetOutputStreamInfo() after each SetOutputType()

Approval Request Comment
[Feature/regressing bug #]: mp4 media
[User impact if declined]:
Uncertain.  Requesting approval based on the possibility that this might help with shutdown or video playback hangs tracked in bug 1129455.

[Describe test coverage new/current, TreeHerder]:
There are some web platform tests and mochitests, but I don't know whether or not any would or what exactly would trigger the scenario addressed here in handling responses from OS libraries.
[Risks and why]: simple patch, so low risk.
[String/UUID change made/needed]: none.
Attachment #8571088 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 6

3 years ago
Comment on attachment 8571088 [details] [diff] [review]
GetOutputStreamInfo() after each SetOutputType()

Approval Request Comment

Adding request for beta to request in comment 5.
Bug 1129455 is a big enough issue and the risk here is low enough that this seems worth taking in the hope that it might help with Bug 1129455.
Attachment #8571088 - Flags: approval-mozilla-beta?
Attachment #8571088 - Flags: approval-mozilla-beta?
Attachment #8571088 - Flags: approval-mozilla-beta+
Attachment #8571088 - Flags: approval-mozilla-aurora?
Attachment #8571088 - Flags: approval-mozilla-aurora+
[Tracking Requested - why for this release]:
status-firefox37: --- → affected
status-firefox38: --- → affected
tracking-firefox37: --- → +
tracking-firefox38: --- → +
(Assignee)

Updated

3 years ago
No longer blocks: 1129455
You need to log in before you can comment on or make changes to this bug.