Closed Bug 1138282 Opened 7 years ago Closed 6 years ago

Extend telemetry for large number of SERVICE_STILL_APPLYING_ON_FAILURE errors

Categories

(Toolkit :: Application Update, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox37 --- unaffected
firefox38 --- unaffected
firefox39 --- fixed
firefox40 --- fixed
firefox-esr31 --- unaffected
firefox-esr38 --- unaffected

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file, 2 obsolete files)

From telemetry of Firefox 36 Beta over 4.5% of service return codes and over 66% of service error return codes are SERVICE_STILL_APPLYING_ON_FAILURE.
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Note that these failures fallback to not using the service.
Summary: Add telemetry for large number of SERVICE_STILL_APPLYING_ON_FAILURE errors → Extend telemetry for large number of SERVICE_STILL_APPLYING_ON_FAILURE errors
Attached patch patch rev1 (obsolete) — Splinter Review
Attached patch patch (obsolete) — Splinter Review
Attachment #8587869 - Attachment is obsolete: true
Attachment #8587900 - Flags: review?(netzen)
Attachment #8587900 - Flags: feedback?(spohl.mozilla.bugs)
Attached patch patchSplinter Review
Forgot t qrefresh :(

 https://treeherder.mozilla.org/#/jobs?repo=try&revision=0917670b8cb7
Attachment #8587900 - Attachment is obsolete: true
Attachment #8587900 - Flags: review?(netzen)
Attachment #8587900 - Flags: feedback?(spohl.mozilla.bugs)
Attachment #8587925 - Flags: review?(netzen)
Attachment #8587925 - Flags: feedback?(spohl.mozilla.bugs)
Attachment #8587925 - Flags: feedback?(spohl.mozilla.bugs) → feedback+
Comment on attachment 8587925 [details] [diff] [review]
patch

Review of attachment 8587925 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/maintenanceservice/workmonitor.cpp
@@ +328,5 @@
>        }
>      }
>    }
> +  // Empty value on putenv is how you remove an env variable in Windows
> +  putenv(const_cast<char*>("MOZ_USING_SERVICE="));

Do you think this change will affect the result?
Attachment #8587925 - Flags: review?(netzen) → review+
(In reply to Brian R. Bondy [:bbondy] from comment #6)
> Comment on attachment 8587925 [details] [diff] [review]
> patch
> 
> Review of attachment 8587925 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/components/maintenanceservice/workmonitor.cpp
> @@ +328,5 @@
> >        }
> >      }
> >    }
> > +  // Empty value on putenv is how you remove an env variable in Windows
> > +  putenv(const_cast<char*>("MOZ_USING_SERVICE="));
> 
> Do you think this change will affect the result?
I highly doubt it.
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/2c5b0df8a9d8
Target Milestone: --- → mozilla40
https://hg.mozilla.org/mozilla-central/rev/2c5b0df8a9d8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8587925 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1137447
[User impact if declined]: It will be more difficult to analyze telemetry for app update which helps to identify areas where we need to improve.
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Little to none. Tested locally. The code wraps the calls in try blocks to prevent it from breaking app update. It is also on m-c.
[String/UUID change made/needed]: None
Attachment #8587925 - Flags: approval-mozilla-aurora?
Comment on attachment 8587925 [details] [diff] [review]
patch

Approving for uplift to aurora. Looks ok on treeherder.
Attachment #8587925 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.