1138282 - Extend telemetry for large number of SERVICE_STILL_APPLYING_ON_FAILURE errors

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

From telemetry of Firefox 36 Beta over 4.5% of service return codes and over 66% of service error return codes are SERVICE_STILL_APPLYING_ON_FAILURE.

Comment 1

[Robert Strong (they/them - no direct email)]

Note that these failures fallback to not using the service.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 4

[Robert Strong (they/them - no direct email)]

Try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd047f052871

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch

Forgot t qrefresh :(

 https://treeherder.mozilla.org/#/jobs?repo=try&revision=0917670b8cb7

Comment 6

[Brian R. Bondy [:bbondy]]

Comment on attachment 8587925 [details] [diff] [review]
patch

Review of attachment 8587925 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/maintenanceservice/workmonitor.cpp
@@ +328,5 @@
>        }
>      }
>    }
> +  // Empty value on putenv is how you remove an env variable in Windows
> +  putenv(const_cast<char*>("MOZ_USING_SERVICE="));

Do you think this change will affect the result?

Comment 7

[Robert Strong (they/them - no direct email)]

(In reply to Brian R. Bondy [:bbondy] from comment #6)
> Comment on attachment 8587925 [details] [diff] [review]
> patch
> 
> Review of attachment 8587925 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/components/maintenanceservice/workmonitor.cpp
> @@ +328,5 @@
> >        }
> >      }
> >    }
> > +  // Empty value on putenv is how you remove an env variable in Windows
> > +  putenv(const_cast<char*>("MOZ_USING_SERVICE="));
> 
> Do you think this change will affect the result?
I highly doubt it.

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/2c5b0df8a9d8

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2c5b0df8a9d8

Comment 10

[Robert Strong (they/them - no direct email)]

Comment on attachment 8587925 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1137447
[User impact if declined]: It will be more difficult to analyze telemetry for app update which helps to identify areas where we need to improve.
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Little to none. Tested locally. The code wraps the calls in try blocks to prevent it from breaking app update. It is also on m-c.
[String/UUID change made/needed]: None

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8587925 [details] [diff] [review]
patch

Approving for uplift to aurora. Looks ok on treeherder.

Comment 12

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-aurora
https://hg.mozilla.org/releases/mozilla-aurora/rev/d4d33c5946d0