1138323 - Heartbeat's browser.selfsupport.url should use https instead of http

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Chris Peterson [:cpeterson]]

We should use HTTPS instead of HTTP for in-product URLs. The server redirects http://self-repair.mozilla.org/en-us/repair to https://self-repair.mozilla.org/en-us/repair anyways.

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: bug1138323.patch

This patch uses HTTPS for the self support url pref.

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: bug1138323.patch

Changed the commit message to mention the name of the reviewer.

Comment 3

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/00c0d934ae62

Comment 4

[Matthew N. [:MattN]]

Backed out: https://hg.mozilla.org/integration/fx-team/rev/d3c18534ce95

> FATAL ERROR: Non-local network connections are disabled and a connection attempt to self-repair.mozilla.org (54.230.116.22) was made.

It looks like a change will need to be made in talos[1] to change the pref to a dummy value.

[1] http://hg.mozilla.org/build/talos/

Comment 5

[Alessio Placitelli [:Dexter]]

> > FATAL ERROR: Non-local network connections are disabled and a connection attempt to self-repair.mozilla.org (54.230.116.22) was made.

That's strange, as I've just changed the URL (which was already there!) to use HTTPS. It should have failed before :/ Sorry about that. I've filed bug 1138823.

Comment 6

[Alessio Placitelli [:Dexter]]

The Talos changes from bug 1138823 were deployed, so we're save to check that in.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/335d3dc298d6

Comment 8

[:Gavin Sharp [email: [e-mail]]]

We should really adjust the code to only ever support loading a selfsupport page over https. It looks like the test server used in test environments supports https too, so that shouldn't be a problem (though we'll need another cycle of Talos changes like bug 1138823...)

Comment 9

[:Gavin Sharp [email: [e-mail]]]

I filed bug 1141052 for that.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/335d3dc298d6

Comment 11

[Andrew McCreight [:mccr8]]

Should this get landed in beta 38?  Also, unless I'm reading this wrong, bug 1111022 got backported, so we shipped this in 37.

Comment 12

[Alessio Placitelli [:Dexter]]

It's not critical, as the server itself redirects to the HTTPS version of the website. But it's probably better to uplift this to beta 38, to avoid confusion.

Comment 13

[Alessio Placitelli [:Dexter]]

Comment on attachment 8571341 [details] [diff] [review]
bug1138323.patch

Approval Request Comment
[Feature/regressing bug #]: 1111022
[User impact if declined]: Self-Support will try to load an HTTP url before getting redirected to use HTTPS.
[Describe test coverage new/current, TreeHerder]: This patch has lived for some time now in m-c. Self-Support testing suite covers this change.
[Risks and why]: Low risk, only impacting on Self-Support.
[String/UUID change made/needed]:

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8571341 [details] [diff] [review]
bug1138323.patch

should be in 38b2

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bfe014dd05ef