1138326 - [RTSP] Move RTSP logic to child process

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RTSP, defect)

Description

[Jonathan Hao (inactive) [:jhao]]

This is to avoid bugs crashing the parent process, causing the device to reboot.

Comment 1

[Jonathan Hao (inactive) [:jhao]]

As you can see in this diagram, RtspControllerParent, RtspController, RTSPSource, RtspConnectionHandler are in parent process. What isn't shown in this diagram is that RtspConnectionHandler sends request by ARTSPConnection and receive RTP packets by ARTPConnection. 

If we want to move all the RTSP related code to child process, including ARTPConnection and ARTSPConnection. We'll have to use TCP Socket in child process. However, the patch in bug 950660 is not ready yet.

An idea is to move just the RtspControllerParent, RtspController, RTSPSource, and RtspConnectionHandler to child process, since they contain the most of the logic, and leave ARTPConnection and ARTSPConnection in the parent process. Then, we wouldn't need the patch in bug 950660.

The drawback of the idea is that we have to design a new IPC interface. Also, by the time bug 950660 is resolved, we may have to change the structure all over again.

Comment 2

[Ethan Tseng [:ethan]]

(In reply to Jonathan Hao [:jhao] from comment #1)
> As you can see in this diagram, RtspControllerParent, RtspController,
> RTSPSource, RtspConnectionHandler are in parent process.
Jonathan, you forgot to attach the link of diagram.

Comment 3

[Jonathan Hao (inactive) [:jhao]]

(In reply to Ethan Tseng [:ethan] from comment #2)
> Jonathan, you forgot to attach the link of diagram.
Oops! Here it is https://wiki.mozilla.org/File:Close_RtspMediaResource.jpg

Comment 4

[Ethan Tseng [:ethan]]

Bug 950660 (Support TCP nr_socket in content process) was resolved fixed, which means we are able to use TCP socket in child process now. Perhaps it is worth to proceed this refactoring bug.

Comment 5

[Jonathan Hao (inactive) [:jhao]]

Closing this bug since no one works on RTSP anymore.