1138359 - Cocoa native theme code needs to consider writing mode for padding of button contents

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jonathan Kew [:jfkthame]]

On OS X, a button such as

  <button>Click Me</button>

gets padding at the beginning and end of the text, thanks to margins returned by nsNativeThemeCocoa::GetWidgetBorder.

However, with a vertical writing-mode button

  <button style="writing-mode:vertical-lr">Click Me</button>

the padding gets applied "over" and "under" the text rather than at the start and end, because it is still specified in physical terms as going on the left and right.

To fix this, we need to make the nsNativeThemeCocoa pay attention to the writing mode (not only to LTR/RTL directionality, which it already considers in certain cases) and remap the padding accordingly.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Make the margins of native-themed Cocoa buttons aware of writing mode

Comment 2

[Jonathan Kew [:jfkthame]]

Note that while this fixes the margins of the button contents (and hence the sizing of the button itself), it doesn't address the fact that vertical writing-mode buttons still don't get the nice rounded corners that we expect on horizontal ones.

That's because we automatically switch to rectangular buttons above a height of 26px (see DO_SQUARE_BUTTON_HEIGHT in nsNativeThemeCocoa.mm), as the rounded buttons look bad at larger heights.

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/05dc91957f46

Comment 4

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/05dc91957f46