1138442 - Parity-disable Mulet reftests with B2G

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Let's skip/disable on Mulet what is already skipped on B2G/B2G Desktop

Comment 1

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Attachment: Disable some reftests on Mulet r=...

Comment 2

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Comment on attachment 8571379 [details] [diff] [review]
Disable some reftests on Mulet r=...

I know it's a very huge list. The rationale is that I've disabled on Mulet everything that was already disabled on B2G/B2G Desktop.

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8571379 [details] [diff] [review]
Disable some reftests on Mulet r=...

Looks like this wasn't done in this patch, but b2gIsMulet sounds pretty awkward, I would have preferred a simple 'Mulet' (if it's not too late).

Could this also be auto-generated to add a comment along the lines of "# initial mulet triage" to each test it disables?

Comment 4

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 8571379 [details] [diff] [review]
> Disable some reftests on Mulet r=...
> 
> Looks like this wasn't done in this patch, but b2gIsMulet sounds pretty
> awkward, I would have preferred a simple 'Mulet' (if it's not too late).

Nope, I've just removed the checkin-needed on the patch that adds this. I'll change it tomorrow.

> 
> Could this also be auto-generated to add a comment along the lines of "#
> initial mulet triage" to each test it disables?

I'm not sure how you want that we auto-generate this ? I'll add the comment.

Comment 5

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Attachment: Disable some reftests on Mulet r=ahal

Comment 6

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Attachment: Disable some reftests on Mulet r=ahal

Comment 7

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

And one slipped through :(
>  REFTEST TEST-UNEXPECTED-FAIL | | EXCEPTION: ReferenceError: b2gIsMulet is not defined

Comment 8

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Attachment: Disable some reftests on Mulet r=ahal

Comment 9

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Attachment: Disable some reftests on Mulet r=ahal

Comment 10

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=13e6c3ec48da&exclusion_profile=false

We are on good track: all the remaining tests to further skip to get full green are some that are not skipped on B2G or B2G Desktop.

Comment 11

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Attachment: Disable reftests on Mulet in parity with B2G/B2G Desktop r=ahal

Comment 12

[Andrew Halberstadt [:ahal]]

Comment on attachment 8573922 [details] [diff] [review]
Disable reftests on Mulet in parity with B2G/B2G Desktop r=ahal

Review of attachment 8573922 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, lgtm! I didn't inspect each file closely, so r+ assuming it's been tested. I imagine there are some false negatives in here, so would be good to file a follow up bug to track re-enabling some of these tests at some point in the future.

Comment 13

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Of course.

Comment 14

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Filed bug 1140554.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing.

Comment 16

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Attachment: Disable reftests on Mulet in parity with B2G/B2G Desktop r=ahal

Comment 17

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Comment on attachment 8574703 [details] [diff] [review]
Disable reftests on Mulet in parity with B2G/B2G Desktop r=ahal

Rebased.

Comment 18

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Attachment: Disable reftests on Mulet in parity with B2G/B2G Desktop r=ahal

Comment 19

[Alexandre LISSY :gerard-majax [PTO 12/12/2022-15/02/2023]]

Comment on attachment 8575185 [details] [diff] [review]
Disable reftests on Mulet in parity with B2G/B2G Desktop r=ahal

Carrying r+, rebased.

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/0454221c3df7

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0454221c3df7