Closed
Bug 1138442
Opened 10 years ago
Closed 10 years ago
Parity-disable Mulet reftests with B2G
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
2.2 S8 (20mar)
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file, 7 obsolete files)
443.81 KB,
patch
|
gerard-majax
:
review+
|
Details | Diff | Splinter Review |
Let's skip/disable on Mulet what is already skipped on B2G/B2G Desktop
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8571379 [details] [diff] [review]
Disable some reftests on Mulet r=...
I know it's a very huge list. The rationale is that I've disabled on Mulet everything that was already disabled on B2G/B2G Desktop.
Attachment #8571379 -
Flags: review?(ahalberstadt)
Comment 3•10 years ago
|
||
Comment on attachment 8571379 [details] [diff] [review]
Disable some reftests on Mulet r=...
Looks like this wasn't done in this patch, but b2gIsMulet sounds pretty awkward, I would have preferred a simple 'Mulet' (if it's not too late).
Could this also be auto-generated to add a comment along the lines of "# initial mulet triage" to each test it disables?
Flags: needinfo?(lissyx+mozillians)
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 8571379 [details] [diff] [review]
> Disable some reftests on Mulet r=...
>
> Looks like this wasn't done in this patch, but b2gIsMulet sounds pretty
> awkward, I would have preferred a simple 'Mulet' (if it's not too late).
Nope, I've just removed the checkin-needed on the patch that adds this. I'll change it tomorrow.
>
> Could this also be auto-generated to add a comment along the lines of "#
> initial mulet triage" to each test it disables?
I'm not sure how you want that we auto-generate this ? I'll add the comment.
Flags: needinfo?(lissyx+mozillians)
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8571379 -
Attachment is obsolete: true
Attachment #8571379 -
Flags: review?(ahalberstadt)
Assignee | ||
Updated•10 years ago
|
Attachment #8571909 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
And one slipped through :(
> REFTEST TEST-UNEXPECTED-FAIL | | EXCEPTION: ReferenceError: b2gIsMulet is not defined
Assignee | ||
Comment 8•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8572018 -
Attachment is obsolete: true
Assignee | ||
Comment 9•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8572159 -
Attachment is obsolete: true
Assignee | ||
Comment 10•10 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=13e6c3ec48da&exclusion_profile=false
We are on good track: all the remaining tests to further skip to get full green are some that are not skipped on B2G or B2G Desktop.
Assignee | ||
Comment 11•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8573315 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8573922 -
Flags: review?(ahalberstadt)
Comment 12•10 years ago
|
||
Comment on attachment 8573922 [details] [diff] [review]
Disable reftests on Mulet in parity with B2G/B2G Desktop r=ahal
Review of attachment 8573922 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, lgtm! I didn't inspect each file closely, so r+ assuming it's been tested. I imagine there are some false negatives in here, so would be good to file a follow up bug to track re-enabling some of these tests at some point in the future.
Attachment #8573922 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 13•10 years ago
|
||
Of course.
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 14•10 years ago
|
||
Filed bug 1140554.
Assignee | ||
Comment 16•10 years ago
|
||
Assignee | ||
Comment 17•10 years ago
|
||
Comment on attachment 8574703 [details] [diff] [review]
Disable reftests on Mulet in parity with B2G/B2G Desktop r=ahal
Rebased.
Flags: needinfo?(ryanvm)
Attachment #8574703 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Attachment #8573922 -
Attachment is obsolete: true
Updated•10 years ago
|
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
Assignee | ||
Comment 18•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8574703 -
Attachment is obsolete: true
Assignee | ||
Comment 19•10 years ago
|
||
Comment on attachment 8575185 [details] [diff] [review]
Disable reftests on Mulet in parity with B2G/B2G Desktop r=ahal
Carrying r+, rebased.
Attachment #8575185 -
Flags: review+
Comment 20•10 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S8 (20mar)
Updated•10 years ago
|
Whiteboard: [systemsfe]
You need to log in
before you can comment on or make changes to this bug.
Description
•