1138489 - Remove JSPROP_INDEX

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

This API feature is unused. The #define can be renamed to JSPROP_RESERVED_BIT since we use it internally.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Remove JSPROP_INDEX

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8578542 [details] [diff] [review]
Remove JSPROP_INDEX

Review of attachment 8578542 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.h
@@ +895,5 @@
>                                             property; don't copy the property on
>                                             set of the same-named property in an
>                                             object that delegates to a prototype
>                                             containing this property */
> +#define JSPROP_RESERVED_BIT     0x80    /* internal use only */

JSPROP_INTERNAL_USE_BIT would be a better name.  "internal use" and "reserved" are really different meanings, aren't they?

Comment 3

[Jason Orendorff [:jorendorff]]

https://tbpl.mozilla.org/?tree=Try&rev=4fa3b8ee8eaf

Comment 4

[Jason Orendorff [:jorendorff]]

https://tbpl.mozilla.org/?tree=Try&rev=765b145f7661

Comment 5

[Jason Orendorff [:jorendorff]]

https://tbpl.mozilla.org/?tree=Try&rev=af9c9ff307d0

Comment 6

[Jason Orendorff [:jorendorff]]

https://tbpl.mozilla.org/?tree=Try&rev=56da02a2959a

Comment 7

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1683c18d7308

Comment 8

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/192e8bcb8b80

Comment 9

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/192e8bcb8b80