1138518 - Add JS template strings to the autoclose brackets list

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect)

Description

[Ian Moody [:Kwan] (UTC+1)]

bz already filed this upstream https://github.com/codemirror/CodeMirror/issues/3110 after a discussion in #devtools, but it turns out we override the list locally anyway in 
https://hg.mozilla.org/mozilla-central/file/eea6188b9b05/browser/devtools/sourceeditor/editor.js#l158
so can just add them there.  Patch incoming.

Comment 1

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Add JS template string (`) to autoCloseBrackets

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8571437 [details] [diff] [review]
Add JS template string (`) to autoCloseBrackets

Review of attachment 8571437 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good, but this test will need to be updated or else it will fail with the patch applied: https://dxr.mozilla.org/mozilla-central/source/browser/devtools/sourceeditor/test/browser_editor_prefs.js#74.

Comment 3

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Add JS template string (`) to autoCloseBrackets, with test update

(In reply to Brian Grinstead [:bgrins] from comment #2)
> Comment on attachment 8571437 [details] [diff] [review]
> Add JS template string (`) to autoCloseBrackets
> 
> Review of attachment 8571437 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Sounds good, but this test will need to be updated or else it will fail with
> the patch applied:
> https://dxr.mozilla.org/mozilla-central/source/browser/devtools/sourceeditor/
> test/browser_editor_prefs.js#74.

Ah, apologies for missing this.  Updated and run tests locally and passes, and try run at 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=04bb87cb4e00

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8571461 [details] [diff] [review]
Add JS template string (`) to autoCloseBrackets, with test update

Review of attachment 8571461 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.  Would you mind updating the commit message to mention that this is for the devtools source editor, and alsoadd r=bgrins at the end of the message?

Comment 5

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Add JS template string (`) to autoCloseBrackets for the DevTools Source Editor. r=bgrins

(In reply to Brian Grinstead [:bgrins] from comment #4)
> Comment on attachment 8571461 [details] [diff] [review]
> Add JS template string (`) to autoCloseBrackets, with test update
> 
> Review of attachment 8571461 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice.  Would you mind updating the commit message to mention that this is
> for the devtools source editor, and alsoadd r=bgrins at the end of the
> message?

Sure, done.

Comment 6

[Ian Moody [:Kwan] (UTC+1)]

Try run in comment #3 all-green.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/cf9240526d96

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cf9240526d96