Closed Bug 1138527 Opened 5 years ago Closed 5 years ago

when font inflation is enabled, CSS ruby should not be inflated differently from the base text

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: jfkthame, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Currently, we apply font inflation calculations to ruby text independently of the calculation for the base text. This means we're liable to inflate the ruby annotation much more than the base, and thereby lose the expected size contrast and mess up the layout.

I think that for <rt>, we should inflate only as much as the inflation being applied to the base text, even though this will typically leave the ruby text smaller than the minimum size being applied to normal text in the same inflation container.
Here's a reftest that currently fails because we inflate the ruby text independently of its base text.
Assignee: nobody → quanxunzhen
Attached patch patchSplinter Review
Attachment #8571645 - Flags: review?(roc)
Identical to jfkthame's patch, except the order in reftest.list and removal of "fails". Thanks for the great reftest, jfkthame.
Attachment #8571435 - Attachment is obsolete: true
Attachment #8571646 - Flags: review?(roc)
Version: unspecified → Trunk
Is it really necessary to modify that code, or should you instead be making sure that ruby annotation containers don't end up being a font inflation container?
I don't think ruby annotation containers are ever font inflation container. [1] (Though some code there doesn't use a proper name.)

[1] https://dxr.mozilla.org/mozilla-central/source/layout/generic/nsFrame.cpp#441
https://hg.mozilla.org/mozilla-central/rev/08e06ab7702a
https://hg.mozilla.org/mozilla-central/rev/2330bb9f7da0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.