If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

when font inflation is enabled, CSS ruby should not be inflated differently from the base text

RESOLVED FIXED in Firefox 39

Status

()

Core
Layout: Text
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jfkthame, Assigned: xidorn)

Tracking

(Blocks: 1 bug)

Trunk
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Currently, we apply font inflation calculations to ruby text independently of the calculation for the base text. This means we're liable to inflate the ruby annotation much more than the base, and thereby lose the expected size contrast and mess up the layout.

I think that for <rt>, we should inflate only as much as the inflation being applied to the base text, even though this will typically leave the ruby text smaller than the minimum size being applied to normal text in the same inflation container.
(Reporter)

Comment 1

3 years ago
Created attachment 8571435 [details] [diff] [review]
Reftest for application of font inflation to ruby

Here's a reftest that currently fails because we inflate the ruby text independently of its base text.
(Assignee)

Updated

3 years ago
Assignee: nobody → quanxunzhen
(Assignee)

Comment 2

3 years ago
Created attachment 8571645 [details] [diff] [review]
patch
Attachment #8571645 - Flags: review?(roc)
(Assignee)

Comment 3

3 years ago
Created attachment 8571646 [details] [diff] [review]
patch for reftest

Identical to jfkthame's patch, except the order in reftest.list and removal of "fails". Thanks for the great reftest, jfkthame.
Attachment #8571435 - Attachment is obsolete: true
Attachment #8571646 - Flags: review?(roc)
(Assignee)

Updated

3 years ago
Version: unspecified → Trunk
Attachment #8571645 - Flags: review?(roc) → review+
Attachment #8571646 - Flags: review?(roc) → review+
(Assignee)

Comment 4

3 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6afcb2625bce
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/08e06ab7702a
https://hg.mozilla.org/integration/mozilla-inbound/rev/2330bb9f7da0
Is it really necessary to modify that code, or should you instead be making sure that ruby annotation containers don't end up being a font inflation container?
(Assignee)

Comment 7

3 years ago
I don't think ruby annotation containers are ever font inflation container. [1] (Though some code there doesn't use a proper name.)

[1] https://dxr.mozilla.org/mozilla-central/source/layout/generic/nsFrame.cpp#441
https://hg.mozilla.org/mozilla-central/rev/08e06ab7702a
https://hg.mozilla.org/mozilla-central/rev/2330bb9f7da0
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.