1138591 - Remove the `devtools.debugger.chrome-enabled` pref

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

We should just rely on the `devtools.chrome.enabled` pref for whatever we are still using the old `devtools.debugger.chrome-enabled` pref for. This way, one pref can control enabling and disabling all the chrome features for devtools and you don't have to hunt down various disparate prefs.

TLDR:

Good: devtools.chrome.enabled

Bad: devtools.debugger.chrome-enabled

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

All places using devtools.debugger.chrome-enabled:

https://dxr.mozilla.org/mozilla-central/search?q=devtools.debugger.chrome-enabled&case=false

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

devtools.debugger.chrome-enabled was just a kill-switch pref that we introduced when the browser debugger landed, in case we needed to disable the feature before release (devtools.chrome.enabled was already used in the scratchpad so couldn't be used as a kill-switch). We don't really have a use for it any longer.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: bz://1138591/jryans

/r/6245 - Bug 1138591 - Remove the chrome-enabled pref. r=past

Pull down this commit:

hg pull review -r c03dfbc905c47aeb34d4a3817e945258199b27ae

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ca847fc5214

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8584974 [details]
MozReview Request: bz://1138591/jryans

https://reviewboard.mozilla.org/r/6243/#review5239

Ship It!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/77a2c0f13869

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Nick, did you have specific wiki pages in mind?  I am not finding any that mentioned this pref at the moment.

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to J. Ryan Stinnett [:jryans] from comment #7)
> Nick, did you have specific wiki pages in mind?  I am not finding any that
> mentioned this pref at the moment.

I was thinking of https://wiki.mozilla.org/DevTools/Hacking, but it looks like we don't explicitly mention it there -- just have the checkbox in the options. Perfect! Sorry!

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/77a2c0f13869

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1138591 - Remove the chrome-enabled pref. r=past