Closed Bug 1138591 Opened 5 years ago Closed 5 years ago

Remove the `devtools.debugger.chrome-enabled` pref

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set

Tracking

(firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: fitzgen, Assigned: jryans)

Details

(Whiteboard: [devtools-wiki-docs-needed])

Attachments

(1 file, 1 obsolete file)

We should just rely on the `devtools.chrome.enabled` pref for whatever we are still using the old `devtools.debugger.chrome-enabled` pref for. This way, one pref can control enabling and disabling all the chrome features for devtools and you don't have to hunt down various disparate prefs.

TLDR:

Good: devtools.chrome.enabled

Bad: devtools.debugger.chrome-enabled
devtools.debugger.chrome-enabled was just a kill-switch pref that we introduced when the browser debugger landed, in case we needed to disable the feature before release (devtools.chrome.enabled was already used in the scratchpad so couldn't be used as a kill-switch). We don't really have a use for it any longer.
Attached file MozReview Request: bz://1138591/jryans (obsolete) —
/r/6245 - Bug 1138591 - Remove the chrome-enabled pref. r=past

Pull down this commit:

hg pull review -r c03dfbc905c47aeb34d4a3817e945258199b27ae
Attachment #8584974 - Flags: review?(past)
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ca847fc5214
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8584974 - Flags: review?(past) → review+
Whiteboard: [devtools-wiki-docs-needed]
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/77a2c0f13869
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [devtools-wiki-docs-needed] → [devtools-wiki-docs-needed][fixed-in-fx-team]
Nick, did you have specific wiki pages in mind?  I am not finding any that mentioned this pref at the moment.
Flags: needinfo?(nfitzgerald)
(In reply to J. Ryan Stinnett [:jryans] from comment #7)
> Nick, did you have specific wiki pages in mind?  I am not finding any that
> mentioned this pref at the moment.

I was thinking of https://wiki.mozilla.org/DevTools/Hacking, but it looks like we don't explicitly mention it there -- just have the checkbox in the options. Perfect! Sorry!
Flags: needinfo?(nfitzgerald)
https://hg.mozilla.org/mozilla-central/rev/77a2c0f13869
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [devtools-wiki-docs-needed][fixed-in-fx-team] → [devtools-wiki-docs-needed]
Target Milestone: --- → Firefox 40
Attachment #8584974 - Attachment is obsolete: true
Attachment #8619635 - Flags: review+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.