Closed Bug 1138591 Opened 5 years ago Closed 5 years ago
Remove the `devtools
.debugger .chrome-enabled` pref
39 bytes, text/x-review-board-request
We should just rely on the `devtools.chrome.enabled` pref for whatever we are still using the old `devtools.debugger.chrome-enabled` pref for. This way, one pref can control enabling and disabling all the chrome features for devtools and you don't have to hunt down various disparate prefs. TLDR: Good: devtools.chrome.enabled Bad: devtools.debugger.chrome-enabled
All places using devtools.debugger.chrome-enabled: https://dxr.mozilla.org/mozilla-central/search?q=devtools.debugger.chrome-enabled&case=false
devtools.debugger.chrome-enabled was just a kill-switch pref that we introduced when the browser debugger landed, in case we needed to disable the feature before release (devtools.chrome.enabled was already used in the scratchpad so couldn't be used as a kill-switch). We don't really have a use for it any longer.
/r/6245 - Bug 1138591 - Remove the chrome-enabled pref. r=past Pull down this commit: hg pull review -r c03dfbc905c47aeb34d4a3817e945258199b27ae
Attachment #8584974 - Flags: review?(past)
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8584974 - Flags: review?(past) → review+
Comment on attachment 8584974 [details] MozReview Request: bz://1138591/jryans https://reviewboard.mozilla.org/r/6243/#review5239 Ship It!
Whiteboard: [devtools-wiki-docs-needed] → [devtools-wiki-docs-needed][fixed-in-fx-team]
Nick, did you have specific wiki pages in mind? I am not finding any that mentioned this pref at the moment.
(In reply to J. Ryan Stinnett [:jryans] from comment #7) > Nick, did you have specific wiki pages in mind? I am not finding any that > mentioned this pref at the moment. I was thinking of https://wiki.mozilla.org/DevTools/Hacking, but it looks like we don't explicitly mention it there -- just have the checkbox in the options. Perfect! Sorry!
You need to log in before you can comment on or make changes to this bug.