1138711 - Fix search accessibility label

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Brian Nicholson (:bnicholson)]

Currently, the search accessibility label for engines is broken. The label is "%@ search for %@", where the first argument should correspond to the search engine name, and the second argument should correspond to the search query. Problem is, we don't update these labels every time the search query changes, so the query in the label is always blank ("<engine> search for ").

We could update the label every time the query changes, but an easier fix would be to just omit the query from the label altogether. Presumably, the user already knows what they're searching for by the time they go to these buttons.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Pull request

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8571625 [details] [review]
Pull request

Expedient.  These are for the search list items, not the suggestion pills, right?  So there is only one for each engine?

Comment 3

[Brian Nicholson (:bnicholson)]

Yep, correct.