1138721 - Application reputation should check mac file extensions

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[[:mmc] Monica Chew (no longer reading bugmail)]

file.MatchesExtension(FILE_PATH_LITERAL(".dmg")) ||
      file.MatchesExtension(FILE_PATH_LITERAL(".pkg")) ||
      file.MatchesExtension(FILE_PATH_LITERAL(".osx")) ||
      file.MatchesExtension(FILE_PATH_LITERAL(".app")) ||

These are new since application reputation was written.

Comment 1

[[:mmc] Monica Chew (no longer reading bugmail)]

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/safe_browsing/download_protection_util.cc

Comment 2

[François Marier [:francois]]

Attachment: Fix the generate_csd.sh script

Comment 3

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8584293 [details] [diff] [review]
Fix the generate_csd.sh script

Review of attachment 8584293 [details] [diff] [review]:
-----------------------------------------------------------------

See https://bugzilla.mozilla.org/show_bug.cgi?id=1024774#c99. Please coordinate with fitzgen.

Comment 4

[François Marier [:francois]]

Part 0 of fitzgen's patch will add the missing MAC_EXECUTABLE enum value.

Comment 5

[François Marier [:francois]]

Attachment: Small improvements to fitzgen's script (DO NOT LAND)

I probably won't push the script as part of this bug, but I want to keep an updated copy of it.

Comment 6

[François Marier [:francois]]

Attachment: Include the download_type when doing remote lookups

Monica, I'm thinking of landing this now so that it can be in Fx39, and then adding the Mac extensions once fitzgen has updated protobuf. What do you think?

Comment 7

[François Marier [:francois]]

Attachment: Add Mac extensions

Comment 8

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8585293 [details] [diff] [review]
Include the download_type when doing remote lookups

Review of attachment 8585293 [details] [diff] [review]:
-----------------------------------------------------------------

LG, but missing a change to test_app_rep_windows to update the size of the request.

Comment 9

[[:mmc] Monica Chew (no longer reading bugmail)]

39 is merging today but you can land this before https://bugzilla.mozilla.org/show_bug.cgi?id=1024774 if you want to get it out of your queue. Since you turned on remote lookups for Mac in 39 I think it would make sense to uplift the mac extensions changes to 39.

Comment 10

[François Marier [:francois]]

Attachment: Add download type and mac extensions

Comment 11

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8586566 [details] [diff] [review]
Add download type and mac extensions

Review of attachment 8586566 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thank you.

Comment 12

[François Marier [:francois]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c463721f7e8d

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22b1b2e2f999

Comment 14

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/22b1b2e2f999

Comment 15

[François Marier [:francois]]

Comment on attachment 8586566 [details] [diff] [review]
Add download type and mac extensions

Approval Request Comment
[Feature/regressing bug #]: 1138721
[User impact if declined]: The patch for 1111741 in Fx 39 added safebrowsing download lookups on Mac but without this follow-up patch, the Mac file types aren't checked.
[Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=67de6e8b2e7d
[Risks and why]: If Mac remote lookups are broken in 1111741 then this patch will amplify the problem.
[String/UUID change made/needed]: None

Comment 16

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8586566 [details] [diff] [review]
Add download type and mac extensions

Approved for uplift to aurora.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1889221f5491

Comment 18

[François Marier [:francois]]

Release Note Request (optional, but appreciated)
[Why is this notable]: We now submit metadata about downloaded Mac binaries (e.g. .dmg) to the Google detection service
[Suggested wording]: The malware detection service for downloads now covers common Mac extensions
[Links (documentation, blog post, etc)]:

Comment 19

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Changing wording to "file extensions" for clarity

Comment 20

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

"file types", even. "extensions" is the part confusing people.