1138727 - IsNuwaProcess() should exist in non-Nuwa builds

Status: RESOLVED WONTFIX

(Core :: DOM: Content Processes, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

We have a bunch of places in the tree that look like this:
http://mxr.mozilla.org/mozilla-central/source/dom/ipc/ContentParent.h#227

It would be better if we had this:

#if !defined(MOZ_NUWA_PROCESS)
MFBT_API bool
IsNuwaProcess() {
  return false;
}
#endif

The only tricky part is deciding which header file it should live in. One way is to change Nuwa.h to be unconditionally included and then change most of its content to be MOZ_NUWA_PROCESS-only. But maybe there's a better way.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I agree in principle.  I don't have strong feelings about the implementation details.

Comment 2

[Cervantes Yu [:cyu] [:cervantes]]

The one in ContentParent.h actually resolves to ContentParent::IsNuwaProcess(), not ::IsNuwaProcess(). See http://mxr.mozilla.org/mozilla-central/source/dom/ipc/ContentParent.h#213

Comment 3

[Jan Beich]

Nuwa is gone after bug 1284674.