Closed
Bug 1138757
Opened 10 years ago
Closed 10 years ago
[B2G][SMS] Incorrect logic to identify the invalid port numbers in CDMA WAP Push.
Categories
(Firefox OS Graveyard :: RIL, defect, P1)
Tracking
(blocking-b2g:2.2+, firefox37 wontfix, firefox38 wontfix, firefox39 fixed, b2g-v1.4 unaffected, b2g-v2.0 unaffected, b2g-v2.0M unaffected, b2g-v2.1 unaffected, b2g-v2.1S unaffected, b2g-v2.2 fixed, b2g-master fixed)
Tracking | Status | |
---|---|---|
firefox37 | --- | wontfix |
firefox38 | --- | wontfix |
firefox39 | --- | fixed |
b2g-v1.4 | --- | unaffected |
b2g-v2.0 | --- | unaffected |
b2g-v2.0M | --- | unaffected |
b2g-v2.1 | --- | unaffected |
b2g-v2.1S | --- | unaffected |
b2g-v2.2 | --- | fixed |
b2g-master | --- | fixed |
People
(Reporter: bevis, Assigned: bevis)
References
Details
(Keywords: regression)
Attachments
(2 files)
1.77 KB,
patch
|
edgar
:
review+
bajaj
:
approval-mozilla-b2g37+
|
Details | Diff | Splinter Review |
3.69 KB,
patch
|
edgar
:
review+
bajaj
:
approval-mozilla-b2g37+
|
Details | Diff | Splinter Review |
This is a regression of bug 873351,
We should identify invalid port number of CDMA WAP Push with !== instead of === in [1].
A test case is also required to improve the test coverage.
[1] https://hg.mozilla.org/mozilla-central/rev/c8057e079f2d#l2.13
Assignee | ||
Comment 2•10 years ago
|
||
Hi Edgar,
Sorry to have this regression caused by bug 873351.
May I have your review for this fix?
Thanks!
Attachment #8571852 -
Flags: review?(echen)
Assignee | ||
Comment 3•10 years ago
|
||
This is to improve the test coverage of CDMA Wap Push.
Hi Edgar,
May I have your review for this change?
Thanks!
Attachment #8571853 -
Flags: review?(echen)
Updated•10 years ago
|
Attachment #8571852 -
Flags: review?(echen) → review+
Comment 4•10 years ago
|
||
Comment on attachment 8571853 [details] [diff] [review]
Part 2 v1: Add Test Coverage for CDMA Wap Push. r=echen
Review of attachment 8571853 [details] [diff] [review]:
-----------------------------------------------------------------
Nice, thank you.
Attachment #8571853 -
Flags: review?(echen) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8571852 -
Attachment description: Part 1 v1: Fix the logic of checking invalid port in CDMA WAP Push. → Part 1 v1: Fix the logic of checking invalid port in CDMA WAP Push. r=echen
Assignee | ||
Updated•10 years ago
|
Attachment #8571853 -
Attachment description: Part 2 v1: Add Test Coverage for CDMA Wap Push. → Part 2 v1: Add Test Coverage for CDMA Wap Push. r=echen
Assignee | ||
Comment 5•10 years ago
|
||
Update try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9c6cf981277
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/c6e3576bab27
https://hg.mozilla.org/integration/b2g-inbound/rev/82be6cb64840
Flags: in-testsuite+
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c6e3576bab27
https://hg.mozilla.org/mozilla-central/rev/82be6cb64840
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: 2.2 S8 (20mar) → 2.2 S7 (6mar)
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8571852 [details] [diff] [review]
Part 1 v1: Fix the logic of checking invalid port in CDMA WAP Push. r=echen
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 873351
User impact if declined: Device can not identify CDMA Wap Push correctly if it is composed in multiple segments and received in reversed order.
Testing completed: Yes, new test case is included.
Risk to taking this patch (and alternatives if risky): No.
String or UUID changes made by this patch:No.
Attachment #8571852 -
Flags: approval-mozilla-b2g37?
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8571853 [details] [diff] [review]
Part 2 v1: Add Test Coverage for CDMA Wap Push. r=echen
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 873351
User impact if declined: Device can not identify CDMA Wap Push correctly if it is composed in multiple segments and received in reversed order.
Testing completed: Yes, new test case is included.
Risk to taking this patch (and alternatives if risky): No.
String or UUID changes made by this patch:No.
Attachment #8571853 -
Flags: approval-mozilla-b2g37?
Updated•10 years ago
|
Attachment #8571852 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
Updated•10 years ago
|
Attachment #8571853 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
Comment 10•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/d1c2dd2f5d4f
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f850ac0af68a
status-firefox37:
--- → wontfix
status-firefox38:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•