1138777 - [EME] Don't do sync dispatch in gmp-clearkey AudioDecoder

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I took out the sync task dispatch of VideoDecoder in bug 1136986, but realised that I can also do the same for AudioDecoder.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Do the same thing that I did for VideoDecoder in bug 1136986 for AudioDecoder.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9447230463a5

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9447230463a5

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

I think this can ride the trains and doesn't need uplift.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Chris Pearce (:cpearce) from comment #4)
> I think this can ride the trains and doesn't need uplift.

This actually fixed a hang in EME for Adobe, so it could also hang us, and important patches that need to be uplift bitrot on aurora without this bug's patch, so I think we should uplift it to 38.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8571730 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Potentially we can have deadlocks when playing back EME protected audio content. However our EME streaming partner does not use encrypted audio, so we'll not actually use this code for our launch partner. Others sites testing EME may hit issues here though. I mostly just want this so that bug 1145405 applies cleanly.
[Describe test coverage new/current, TreeHerder]: We have lots of EME mochitests.
[Risks and why]: Seems pretty low risk; EME streaming partner does not use encrypted audio, so we'll not actually use this code for our launch partner.
[String/UUID change made/needed]: None.

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8571730 [details] [diff] [review]
Patch

I think this is small enough that even though we don't expect to execute this code in 38 it is reasonable to take it on Aurora to make applying another patch cleaner. Aurora+

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/530e2db7672d