Closed Bug 1138777 Opened 5 years ago Closed 5 years ago

[EME] Don't do sync dispatch in gmp-clearkey AudioDecoder

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox37 --- wontfix
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I took out the sync task dispatch of VideoDecoder in bug 1136986, but realised that I can also do the same for AudioDecoder.
Attached patch PatchSplinter Review
Do the same thing that I did for VideoDecoder in bug 1136986 for AudioDecoder.
Attachment #8571730 - Flags: review?(edwin)
https://hg.mozilla.org/mozilla-central/rev/9447230463a5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
I think this can ride the trains and doesn't need uplift.
(In reply to Chris Pearce (:cpearce) from comment #4)
> I think this can ride the trains and doesn't need uplift.

This actually fixed a hang in EME for Adobe, so it could also hang us, and important patches that need to be uplift bitrot on aurora without this bug's patch, so I think we should uplift it to 38.
Flags: needinfo?(cpearce)
Comment on attachment 8571730 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Potentially we can have deadlocks when playing back EME protected audio content. However our EME streaming partner does not use encrypted audio, so we'll not actually use this code for our launch partner. Others sites testing EME may hit issues here though. I mostly just want this so that bug 1145405 applies cleanly.
[Describe test coverage new/current, TreeHerder]: We have lots of EME mochitests.
[Risks and why]: Seems pretty low risk; EME streaming partner does not use encrypted audio, so we'll not actually use this code for our launch partner.
[String/UUID change made/needed]: None.
Attachment #8571730 - Flags: approval-mozilla-aurora?
Comment on attachment 8571730 [details] [diff] [review]
Patch

I think this is small enough that even though we don't expect to execute this code in 38 it is reasonable to take it on Aurora to make applying another patch cleaner. Aurora+
Attachment #8571730 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.